Fixing build issues and warnings #26603

bergerhoffer · 2020-10-20T19:53:46Z

Preview: https://fixin-build-issues--ocpdocs.netlify.app/openshift-enterprise/latest/welcome/index.html

bergerhoffer · 2020-10-20T19:55:20Z

_topic_map.yml

FYI @sfortner-RH This is what I commented out per our discussion earlier

openshift-docs-preview-bot · 2020-10-20T19:57:15Z

The preview will be available shortly at:

https://fixin-build-issues--ocpdocs.netlify.com/

bergerhoffer · 2020-10-20T20:11:15Z

modules/olm-terms.adoc

@adellape You can't have more than one level 1 heading (= Heading) in a file, so this was my attempt at fixing this file. Can you take a look and see if this is okay how I added this, or if you have a different way/text you'd rather see?

Preview: https://fixin-build-issues--ocpdocs.netlify.app/openshift-enterprise/latest/operators/understanding/olm-common-terms.html#olm-common-terms-glossary_olm-common-terms

Yes, that works. Thanks!

bergerhoffer · 2020-10-20T20:12:00Z

post_installation_configuration/storage-configuration.adoc

@ahardin-rh Can you check this file? It had some incorrect levels and I just want a sanity check that they indentation/levels are still what you were expecting. Thanks!

Preview: https://fixin-build-issues--ocpdocs.netlify.app/openshift-enterprise/latest/post_installation_configuration/storage-configuration.html

Your changes LGTM! Thanks!

bergerhoffer · 2020-10-20T20:12:46Z

modules/olm-mirroring-catalog.adoc

@adellape Can you check this file too please?

Perfect, thanks. A casualty of a recent un-wrap. 😬

Yep, unfortunately gotta be careful about that happening!

bergerhoffer · 2020-10-20T20:13:06Z

operators/understanding/olm-common-terms.adoc

@adellape This too please

bergerhoffer · 2020-10-20T20:13:40Z

serverless/networking/serverless-ossm.adoc

@JStickler Can you please check this? This is fixing a build warning about being at the wrong level. Thanks!

@bergerhoffer, that's actually a serverless file, so calling @abrennan89 to make the call on this one.

Apologies @JStickler - thanks!

bergerhoffer · 2020-10-20T20:14:11Z

modules/nw-aws-nlb-new-cluster.adoc

@jboxman Can you check this update please?

Your change aligns with the usage elsewhere in the install docs.

bergerhoffer · 2020-10-20T20:14:36Z

modules/migration-installing-cam-operator-ocp-3.adoc

@apinnick This PR is fixing build issues. Can you please check that this fix is correct? Thanks!

Yes, this looks fine.

bergerhoffer · 2020-10-20T20:14:55Z

modules/cluster-logging-collector-log-forward-syslog.adoc

@mburke5678 Can you check the changes in this file please?

@bergerhoffer I think I used === to make the text smaller. Seems to large as ==. Is there a better/proper way to do this? Maybe definition lists?
While you are in the file, could you male Syslog parameters: and Additional RFC5424 syslog parameters consistent? One has a colon and one doesn't. Probably remove the colon?

@mburke5678 Sure thing, removed the colon.

And yeah, you need to go in order of the heading level, you shouldn't use a lower level just because you want the font to be smaller.

If I had to make a suggestion here, I would say that these sections don't really belong in the procedure module, and should probably be reference modules included after the procedure.

And yeah, you need to go in order of the heading level, you shouldn't use a lower level just because you want the font to be smaller.
Makes sense. Not sure why I formatted it this way. Thanks for fixing!

jboxman · 2020-10-20T20:17:47Z

@bergerhoffer thanks been thinking about these for weeks.

vikram-redhat · 2020-10-22T02:33:59Z

/lgtm

Merging to get past build warnings and errors for l10n.

vikram-redhat · 2020-10-22T02:34:17Z

/cherrypick enterprise-4.6

vikram-redhat · 2020-10-22T02:34:27Z

/cherrypick enterprise-4.5

openshift-cherrypick-robot · 2020-10-22T02:34:28Z

@vikram-redhat: new pull request created: #26632

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-10-22T02:34:31Z

@vikram-redhat: #26603 failed to apply on top of branch "enterprise-4.5":

Applying: Fixing build issues and warnings
Using index info to reconstruct a base tree...
M	_topic_map.yml
A	modules/cluster-logging-collector-log-forward-syslog.adoc
M	modules/cnf-debugging-low-latency-cnf-tuning-status.adoc
A	modules/nw-aws-nlb-new-cluster.adoc
A	modules/olm-mirroring-catalog.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/olm-mirroring-catalog.adoc deleted in HEAD and modified in Fixing build issues and warnings. Version Fixing build issues and warnings of modules/olm-mirroring-catalog.adoc left in tree.
CONFLICT (modify/delete): modules/nw-aws-nlb-new-cluster.adoc deleted in HEAD and modified in Fixing build issues and warnings. Version Fixing build issues and warnings of modules/nw-aws-nlb-new-cluster.adoc left in tree.
Auto-merging modules/cnf-debugging-low-latency-cnf-tuning-status.adoc
CONFLICT (content): Merge conflict in modules/cnf-debugging-low-latency-cnf-tuning-status.adoc
CONFLICT (modify/delete): modules/cluster-logging-collector-log-forward-syslog.adoc deleted in HEAD and modified in Fixing build issues and warnings. Version Fixing build issues and warnings of modules/cluster-logging-collector-log-forward-syslog.adoc left in tree.
Auto-merging _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fixing build issues and warnings
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-10-22T02:34:34Z

@vikram-redhat: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/openshift-docs\n ! [rejected] cherry-pick-26603-to-enterprise-4.6 -> cherry-pick-26603-to-enterprise-4.6 (non-fast-forward)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:[email protected]/openshift-cherrypick-robot/openshift-docs'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 20, 2020

bergerhoffer added branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 20, 2020

bergerhoffer added this to the Next Release milestone Oct 20, 2020

bergerhoffer commented Oct 20, 2020

View reviewed changes

Fixing build issues and warnings

478d03c

bergerhoffer force-pushed the fixin-build-issues branch from 8e0d623 to 478d03c Compare October 21, 2020 00:06

vikram-redhat approved these changes Oct 22, 2020

View reviewed changes

vikram-redhat merged commit 91aa104 into openshift:master Oct 22, 2020

openshift-ci-robot assigned vikram-redhat Oct 22, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020

openshift-cherrypick-robot mentioned this pull request Oct 22, 2020

[enterprise-4.6] Fixing build issues and warnings #26632

Merged

This was referenced Oct 25, 2020

Fixing build issues and warnings #26699

Merged

Fixing build issues and warnings #26700

Merged

bergerhoffer deleted the fixin-build-issues branch October 29, 2020 14:37

kalexand-rh mentioned this pull request Nov 2, 2020

modules/update-configuring-image-signature: Fix <11> reference #26220

Closed

Fixing build issues and warnings #26603

Fixing build issues and warnings #26603

Uh oh!

Conversation

bergerhoffer commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-docs-preview-bot commented Oct 20, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jboxman commented Oct 20, 2020

Uh oh!

vikram-redhat commented Oct 22, 2020

Uh oh!

vikram-redhat commented Oct 22, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vikram-redhat commented Oct 22, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Oct 22, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Oct 22, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Oct 22, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

bergerhoffer commented Oct 20, 2020 •

edited

Loading

vikram-redhat commented Oct 22, 2020 •

edited by openshift-ci-robot

Loading

vikram-redhat commented Oct 22, 2020 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Oct 22, 2020 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Oct 22, 2020 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Oct 22, 2020 •

edited by openshift-ci-robot

Loading