Add baremetal section with power-cycle remediation to machine health checks doc #26321

n1r1 · 2020-10-11T12:07:49Z

Modify machine health checks documentation to include an option to trigger power-cycle instead of machine deletion.
This is only relevant for IPI baremetal clusters and starting from OCP 4.5

n1r1 · 2020-10-11T12:11:54Z

cc @JoelSpeed @beekhof

vikram-redhat · 2020-10-13T02:50:10Z

@kalexand-rh can you take a look? @n1r1 which version does it apply to?

n1r1 · 2020-10-13T03:39:17Z

@vikram-redhat
4.5 + (i.e 4.5, 4.6)

JoelSpeed

Added a couple of suggestions to improve the wording, but otherwise I think this is good

modules/machine-health-checks-baremetal.adoc

kalexand-rh

I think this is a great addition, but I think the information would be more effective in different modules.

modules/machine-health-checks-baremetal.adoc

n1r1 · 2020-10-14T13:17:22Z

Thank you both for the feedback.
I made the changes per your suggestions.

JoelSpeed · 2020-10-14T13:22:29Z

LGTM

modules/machine-health-checks-about.adoc

kalexand-rh

@n1r1, thank you! I have a few more suggestions, but this is really good.

kalexand-rh · 2020-11-04T14:53:20Z

modules/machine-health-checks-resource.adoc

Suggested change

<2>

@kalexand-rh is this suggestion still relevant per our last discussion?

If I'll remove this, we will have <2> below explaining about the annotation without any reference in the yaml.
let me know if you want to remove it anyway

@n1r1, I think it might be clearest to provide two yaml sections. Will you PTAL at the commit that I've added?

@kalexand-rh thanks.
Looks good to me

modules/machine-health-checks-resource.adoc

n1r1 · 2020-11-04T18:04:05Z

Thanks @kalexand-rh
I'm not sure I understand the last suggestions.

The annotation is not related to the matchLabel sections.
Here's a full example with that annotation, if it helps to clarify things:

apiVersion: machine.openshift.io/v1beta1
kind: MachineHealthCheck
metadata:
  name: example 
  namespace: openshift-machine-api
  annotations:
    machine.openshift.io/remediation-strategy: external-baremetal
spec:
  selector:
    matchLabels:
      machine.openshift.io/cluster-api-machine-role: <role> 
      machine.openshift.io/cluster-api-machine-type: <role> 
      machine.openshift.io/cluster-api-machineset: <cluster_name>-<label>-<zone> 
  unhealthyConditions:
  - type:    "Ready"
    timeout: "300s" 
    status: "False"
  - type:    "Ready"
    timeout: "300s" 
    status: "Unknown"
  maxUnhealthy: "40%"

netlify · 2021-01-27T20:55:40Z

Deploy preview for osdocs ready!

Built with commit 4116786

https://deploy-preview-26321--osdocs.netlify.app

Modify machine health checks documentation to include an option to trigger power-cycle instead of machine deletion. This is only relevant for IPI baremetal clusters and starting from OCP 4.5 Signed-off-by: Nir <[email protected]>

kalexand-rh · 2021-02-10T19:13:02Z

/cherrypick enterprise-4.5

kalexand-rh · 2021-02-10T19:13:06Z

/cherrypick enterprise-4.6

kalexand-rh · 2021-02-10T19:13:09Z

/cherrypick enterprise-4.7

openshift-cherrypick-robot · 2021-02-10T19:13:46Z

@kalexand-rh: new pull request created: #29380

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-02-10T19:13:52Z

@kalexand-rh: new pull request created: #29381

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-02-10T19:13:55Z

@kalexand-rh: new pull request created: #29382

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2020

JoelSpeed reviewed Oct 13, 2020

View reviewed changes

modules/machine-health-checks-baremetal.adoc Outdated Show resolved Hide resolved

modules/machine-health-checks-baremetal.adoc Outdated Show resolved Hide resolved

kalexand-rh reviewed Oct 13, 2020

View reviewed changes

n1r1 force-pushed the baremetal-machine-healthcheck branch from a89c53e to d7597a8 Compare October 14, 2020 13:11

n1r1 requested a review from kalexand-rh October 26, 2020 07:03

kalexand-rh reviewed Nov 2, 2020

View reviewed changes

modules/machine-health-checks-about.adoc Outdated Show resolved Hide resolved

modules/machine-health-checks-about.adoc Outdated Show resolved Hide resolved

n1r1 force-pushed the baremetal-machine-healthcheck branch from d7597a8 to c273425 Compare November 4, 2020 08:13

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2020

kalexand-rh reviewed Nov 4, 2020

View reviewed changes

n1r1 force-pushed the baremetal-machine-healthcheck branch from c273425 to 856c3db Compare November 30, 2020 06:47

n1r1 requested a review from kalexand-rh November 30, 2020 07:01

n1r1 force-pushed the baremetal-machine-healthcheck branch from 856c3db to 9a5ce86 Compare December 2, 2020 14:02

n1r1 force-pushed the baremetal-machine-healthcheck branch from 9a5ce86 to cf39b18 Compare December 20, 2020 14:54

n1r1 force-pushed the baremetal-machine-healthcheck branch from cf39b18 to 6ef0960 Compare January 25, 2021 06:25

Add power-cycle based remediation for bare metal

4116786

Modify machine health checks documentation to include an option to trigger power-cycle instead of machine deletion. This is only relevant for IPI baremetal clusters and starting from OCP 4.5 Signed-off-by: Nir <[email protected]>

kalexand-rh force-pushed the baremetal-machine-healthcheck branch from 9f22b2d to 4116786 Compare January 28, 2021 13:02

kalexand-rh added branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 labels Feb 10, 2021

kalexand-rh added this to the Next Release milestone Feb 10, 2021

kalexand-rh merged commit 43d64eb into openshift:master Feb 10, 2021

openshift-cherrypick-robot mentioned this pull request Feb 10, 2021

[enterprise-4.5] Add baremetal section with power-cycle remediation to machine health checks doc #29380

Merged

openshift-cherrypick-robot mentioned this pull request Feb 10, 2021

[enterprise-4.6] Add baremetal section with power-cycle remediation to machine health checks doc #29381

Merged

openshift-cherrypick-robot mentioned this pull request Feb 10, 2021

[enterprise-4.7] Add baremetal section with power-cycle remediation to machine health checks doc #29382

Merged

Add baremetal section with power-cycle remediation to machine health checks doc #26321

Add baremetal section with power-cycle remediation to machine health checks doc #26321

Uh oh!

Conversation

n1r1 commented Oct 11, 2020

Uh oh!

n1r1 commented Oct 11, 2020

Uh oh!

vikram-redhat commented Oct 13, 2020

Uh oh!

n1r1 commented Oct 13, 2020

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kalexand-rh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

n1r1 commented Oct 14, 2020

Uh oh!

JoelSpeed commented Oct 14, 2020

Uh oh!

Uh oh!

Uh oh!

kalexand-rh left a comment

Choose a reason for hiding this comment

Uh oh!

kalexand-rh Nov 4, 2020

Choose a reason for hiding this comment

Uh oh!

n1r1 Dec 22, 2020

Choose a reason for hiding this comment

Uh oh!

kalexand-rh Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

n1r1 Jan 28, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

n1r1 commented Nov 4, 2020

Uh oh!

netlify bot commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kalexand-rh commented Feb 10, 2021

Uh oh!

kalexand-rh commented Feb 10, 2021

Uh oh!

kalexand-rh commented Feb 10, 2021

Uh oh!

openshift-cherrypick-robot commented Feb 10, 2021

Uh oh!

openshift-cherrypick-robot commented Feb 10, 2021

Uh oh!

openshift-cherrypick-robot commented Feb 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

netlify bot commented Jan 27, 2021 •

edited

Loading