Skip to content

CNV - Moved xref out of module and into assembly file #26268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ousleyp merged 1 commit into from
Oct 9, 2020
Merged

CNV - Moved xref out of module and into assembly file #26268

ousleyp merged 1 commit into from
Oct 9, 2020

Conversation

@sjhala-ccs
Copy link
Contributor

@sjhala-ccs sjhala-ccs commented Oct 8, 2020 •
edited
Loading

Removed xref from module and moved the link into the assembly file per openshift-docs documentation guidelines.

Issue reported in #26257

Original PR: #24172

Preview build: https://xref-fix-for-pr-24172--ocpdocs.netlify.app/openshift-enterprise/latest/virt/upgrading-virt.html

Peer review needed
Merge/CP to enterprise-4.5 and enterprise-4.6

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2020
@sjhala-ccs sjhala-ccs force-pushed the xref-fix-for-pr-24172 branch from 79b3c39 to 69291b0 Compare October 8, 2020 21:38
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Oct 8, 2020

The preview will be available shortly at:

@vikram-redhat vikram-redhat mentioned this pull request Oct 9, 2020
Closed
ousleyp
ousleyp reviewed Oct 9, 2020
View reviewed changes
Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue but otherwise this LGTM. Thanks for fixing it!

@ousleyp ousleyp added this to the Next Release milestone Oct 9, 2020
@sjhala-ccs sjhala-ccs force-pushed the xref-fix-for-pr-24172 branch from 69291b0 to 9115383 Compare October 9, 2020 14:13
@ousleyp ousleyp merged commit 8b66f76 into openshift:master Oct 9, 2020
@ousleyp
Copy link
Member

ousleyp commented Oct 9, 2020

/cherrypick enterprise-4.5

@ousleyp
Copy link
Member

ousleyp commented Oct 9, 2020

/cherrypick enterprise-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 9, 2020

@ousleyp: new pull request created: #26284

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 9, 2020
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 9, 2020

@ousleyp: new pull request created: #26285

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjhala-ccs sjhala-ccs deleted the xref-fix-for-pr-24172 branch October 9, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ousleyp ousleyp ousleyp left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.5 branch/enterprise-4.6 CNV Label for all CNV PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@sjhala-ccs @openshift-docs-preview-bot @ousleyp @openshift-cherrypick-robot @openshift-ci-robot