Edit /var partitioning section in 4.6 docs

[bobfuru]

PR to update Creating a separate /var partition section of OCP 4.6 docs, as addressed in this thread: https://coreos.slack.com/archives/C999USB0D/p1602165001461900

@yuqi-zhang

Preview link: https://update-var-section--ocpdocs.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/installing-bare-metal.html#installation-user-infra-machines-advanced_vardisk_installing-bare-metal

[openshift-docs-preview-bot]

The preview will be available shortly at:

• https://update-var-section--ocpdocs.netlify.com/

[bobfuru]

@marrusl PTAL

[yuqi-zhang]

I think based on our conversations we need to modify some items here, including the whole machineconfig section. I can't really comment very easily on this PR since your changes only touches a few parts of the doc. So maybe a collaborative doc somewhere would be better, in any case:

1. line 65: partitoin -> partition
2. change all references from /var/log to /var. If we want to talk about /var/log and /var/lib/containers we should do that in separate sections
3. line 145: /dev/nvme0n1 -> this is AWS only. This section is for baremetal, so we should at the very least leave this open as a variable with a footnote on it being the device name of the disk you want to partition
4. line 148/149:

sizeMiB: 47000
startMiB: 47000

We should also make these variables, with a footnote that if you are to partition onto the same disk that sysroot in on, you must at least specify a startMiB (mebibytes) so that it doesn't stomp over your sysroot, as the default sysroot would normally grow to fit the reset of the disk

[bobfuru]

I think based on our conversations we need to modify some items here, including the whole machineconfig section. I can't really comment very easily on this PR since your changes only touches a few parts of the doc. So maybe a collaborative doc somewhere would be better

Thanks for the comments, @yuqi-zhang - that's helpful. Yeah, I realized after creating the PR that commenting might be a challenge but kept it for now to be able to comment inline while seeing the diff.

I've applied your suggestions to the best of my understanding if you want to take a look. I also copied this section to a Google Doc in case it's easier to collaborate that way:
Creating a separate /var partition Both the Gdoc and the PR should have the same wording as of now.

If you need to edit more than what's in this procedure, feel free to add that in the Gdoc. Thanks!

[bobfuru]

@bgilbert Thanks for the comment. I am going to resolve the similar comment in https://github.com/openshift/openshift-docs/pull/25709/files#r498441768 and address the issue here.

[bobfuru]

Thanks for the review, @bgilbert. This will need to be merged tomorrow to make GA cutoff.

Could I please get a LGTM from your or @yuqi-zhang?

[bobfuru]

@openshift/team-documentation PTAL

[sfortner-RH]

I had one small nit, but otherwise LGTM!

[bobfuru]

@bgilbert Made the last couple of changes. Can I please get your approval?

[bgilbert]

LGTM!

[bobfuru]

/cherrypick enterprise-4.6

[openshift-cherrypick-robot]

@bobfuru: new pull request created: #26511

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.