4.6 OCP on OSP release notes. #26195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwelldb
changed the title
Contributor
Author
|
+ @luis5tb |
openshift-ci-robot
added
the
size/S
|
The preview will be available shortly at: |
luis5tb
reviewed
Oct 8, 2020
Contributor
Author
|
Merge should be held pending OSASINFRA-992 status. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
|
992 is resolved, but merge should still be held pending completion of other items. |
openshift-ci-robot
added
the
needs-rebase
* Add known issue with Kuryr Neutron ports Kuryr creates unnecessary Neutron Ports for hostNetworking pods and we won't fix it before GA. This is adding info about the issue. * Apply suggestions from code review Co-authored-by: Max Bridges <[email protected]>
openshift-ci-robot
removed
the
needs-rebase
maxwelldb
removed
the
do-not-merge/hold
Contributor
Author
|
@codyhoag @jeana-redhat Are you able to review this? Don't want to step on your toes, here. |
Contributor
|
I'll take a look 👍 |
codyhoag
reviewed
Oct 15, 2020
Contributor
codyhoag
left a comment
codyhoag
left a comment
There was a problem hiding this comment.
One minor suggestion; otherwise; LGTM!
codyhoag
added
the
peer-review-done
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
Contributor
|
Sorry; will also need commit squashing too @maxwelldb 🙂 |
Contributor
Author
|
Done and merged. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pulling together 4.6 release notes. Let me know if what's up here seems anemic, inaccurate, or incomplete. @racedo @EricArrakis @iamemilio @Fedosin @pierreprinetti @mandre
Feel free to make a PR directly, too: https://github.com/maxwelldb/openshift-docs/blob/osp-4.6-rn/release_notes/ocp-4-6-release-notes.adoc
FYI @codyhoag @jeana-redhat