Fixes to PR #25656 - applies SME feedback #26004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
The preview will be available shortly at: |
bobfuru
added
the
peer-review-needed
Contributor
Author
|
@openshift/team-documentation PTAL |
ahardin-rh
reviewed
Sep 30, 2020
ahardin-rh
reviewed
Sep 30, 2020
ahardin-rh
added
peer-review-done
Contributor
|
Just some minor suggestions from me! 👍 |
bobfuru
force-pushed
the
OSDOCS-1496-v2
branch
from
1b9d14c to
d753b3c
Compare
Contributor
Author
|
/cherrypick enterprise-4.6 |
|
@bobfuru: new pull request created: #26007 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25656 by applying feedback from @jlebon in that PR, which was already merged to master and CP'ed to 4.6. Once this is approved, it can also be merged so that it gets picked up by the review and merge work being done in #25709.