install: ignition_url/rootfs_url only supports HTTP and HTTPS #25989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be clear that the `coreos.inst.ignition_url` and `coreos.inst.rootfs_url` parameters only supports HTTP and HTTPS when installing RHCOS via ISO/PXE.
openshift-ci-robot
added
the
size/S
Member
Author
|
This should be included as part of OCP 4.6 docs. |
bgilbert
approved these changes
Oct 1, 2020
Contributor
bgilbert
left a comment
bgilbert
left a comment
There was a problem hiding this comment.
LGTM generally. One small fix.
| bootstrap Ignition config file, and the `coreos.live.rootfs_url` parameter value is | ||
| the location of the live `rootfs` file. | ||
| the location of the live `rootfs` file. The `coreos.inst.ignition_url` and | ||
| `coreos.inst.rootfs_url` parameters only supports HTTP and HTTPS. |
Contributor
There was a problem hiding this comment.
coreos.live.rootfs_url (also in 3 other cases)
JAORMX
approved these changes
Oct 2, 2020
Contributor
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be clear that the
coreos.inst.ignition_urlandcoreos.inst.rootfs_urlparameters only supports HTTP and HTTPSwhen installing RHCOS via ISO/PXE.