Skip to content

Fix Issue 25610 - expand block reg storage proc #25941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bobfuru merged 1 commit into from
Nov 5, 2020
Merged

Fix Issue 25610 - expand block reg storage proc #25941

bobfuru merged 1 commit into from
Nov 5, 2020
+41 −1

Conversation

@bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Sep 30, 2020 •
edited
Loading

Fixes #25610
Note that a related PR is currently in progress: #25826. Based on the content and merge status of that PR, this PR might also need small revisions for consistency.

@wzheng1 PTAL for QE review, thanks!

PREVIEW LINK: https://issue-25610--ocpdocs.netlify.app/openshift-enterprise/latest/registry/configuring_registry_storage/configuring-registry-storage-vsphere.html#installation-registry-storage-block-recreate-rollout_configuring-registry-storage-vsphere

@bobfuru bobfuru added this to the Next Release milestone Sep 30, 2020
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2020
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Sep 30, 2020

The preview will be available shortly at:

@bobfuru bobfuru mentioned this pull request Sep 30, 2020
Closed
@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 23, 2020

@wzheng1 BUMP - PTAL, this matches up with work completed in #25826.

wzheng1
wzheng1 reviewed Oct 30, 2020
View reviewed changes
bobfuru
bobfuru commented Nov 3, 2020
View reviewed changes
Copy link
Contributor Author

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wzheng1 I responded to your comment. Please approve if this now looks good from QE. Thanks.

@bobfuru
Copy link
Contributor Author

bobfuru commented Nov 3, 2020

@dmage Could you PTAL and let me know if you approve of this addition? 🙇

dmage
dmage reviewed Nov 4, 2020
View reviewed changes
@bobfuru
Copy link
Contributor Author

bobfuru commented Nov 4, 2020

Thanks for the feedback, @dmage - I've updated so that the steps should now make more sense. Let me know if this looks good to you.
@wzheng1 - Can you also ack, please?

@wzheng1
Copy link

wzheng1 commented Nov 5, 2020

LGTM

1 similar comment
@dmage
Copy link
Contributor

dmage commented Nov 5, 2020

LGTM

@bobfuru bobfuru added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 5, 2020
@lbarbeevargas lbarbeevargas self-requested a review November 5, 2020 16:03
lbarbeevargas
lbarbeevargas reviewed Nov 5, 2020
View reviewed changes
Copy link
Contributor

@lbarbeevargas lbarbeevargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobfuru Some small wording suggestions, but LGTM otherwise!

@lbarbeevargas lbarbeevargas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 5, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Nov 5, 2020

Updated and merging, thanks @lbarbeevargas for the feedback!

@bobfuru bobfuru merged commit 2461685 into openshift:master Nov 5, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Nov 5, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@bobfuru
Copy link
Contributor Author

bobfuru commented Nov 5, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@bobfuru
Copy link
Contributor Author

bobfuru commented Nov 5, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 5, 2020 •
edited by openshift-ci-robot
Loading

@bobfuru: new pull request created: #27109

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 5, 2020
Merged
@bobfuru
Copy link
Contributor Author

bobfuru commented Nov 5, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 5, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 5, 2020 •
edited by openshift-ci-robot
Loading

@bobfuru: new pull request created: #27110

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 5, 2020 •
edited by openshift-ci-robot
Loading

@bobfuru: new pull request created: #27111

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru bobfuru deleted the ISSUE-25610 branch November 5, 2020 16:41
This was referenced Nov 5, 2020
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 5, 2020 •
edited by openshift-ci-robot
Loading

@bobfuru: new pull request created: #27112

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@dmage dmage dmage left review comments

@wzheng1 wzheng1 wzheng1 left review comments

@lbarbeevargas lbarbeevargas lbarbeevargas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

Configuring block registry storage for VMware vSphere

7 participants

@bobfuru @openshift-docs-preview-bot @wzheng1 @dmage @openshift-cherrypick-robot @lbarbeevargas @openshift-ci-robot