-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New MCO post-install tasks section #25823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The preview will be available shortly at: |
|
@cgwalters, @yuqi-zhang, @kikisdeliveryservice - PTAL for technical review. I'm helping Chris get these docs over the finish line for OCP 4.6 Thanks! |
|
Will take a look, also cc @runcom |
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and I'm a little confused about what {product-title} is going to be in each of the files as it doesn't seem to be correct if it's OpenShift not RHCOS
bobfuru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor style suggestions and nitpicks. Great work!!
post_installation_configuration/machine-configuration-tasks.adoc
Outdated
Show resolved
Hide resolved
post_installation_configuration/machine-configuration-tasks.adoc
Outdated
Show resolved
Hide resolved
post_installation_configuration/machine-configuration-tasks.adoc
Outdated
Show resolved
Hide resolved
chrisnegus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobfuru I've responded to all the comments. If it looks okay to you, I'm okay with you merging it.
post_installation_configuration/machine-configuration-tasks.adoc
Outdated
Show resolved
Hide resolved
post_installation_configuration/machine-configuration-tasks.adoc
Outdated
Show resolved
Hide resolved
post_installation_configuration/machine-configuration-tasks.adoc
Outdated
Show resolved
Hide resolved
post_installation_configuration/machine-configuration-tasks.adoc
Outdated
Show resolved
Hide resolved
post_installation_configuration/machine-configuration-tasks.adoc
Outdated
Show resolved
Hide resolved
|
/cherrypick enterprise-4.6 |
|
@bobfuru: new pull request created: #26086 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR includes existing modules and creates some new modules that are all gathered together under a new "Machine configuration tasks" section of the "Post-installation configuration" left navigation.