Skip to content

Conversation

@chrisnegus
Copy link
Contributor

This PR includes existing modules and creates some new modules that are all gathered together under a new "Machine configuration tasks" section of the "Post-installation configuration" left navigation.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 28, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@bobfuru
Copy link
Contributor

bobfuru commented Sep 29, 2020

@cgwalters, @yuqi-zhang, @kikisdeliveryservice - PTAL for technical review. I'm helping Chris get these docs over the finish line for OCP 4.6 Thanks!

@yuqi-zhang
Copy link

Will take a look, also cc @runcom

Copy link

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and I'm a little confused about what {product-title} is going to be in each of the files as it doesn't seem to be correct if it's OpenShift not RHCOS

Copy link
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor style suggestions and nitpicks. Great work!!

@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 29, 2020
Copy link
Contributor Author

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobfuru I've responded to all the comments. If it looks okay to you, I'm okay with you merging it.

@bobfuru bobfuru merged commit 052f4ce into openshift:master Oct 2, 2020
@bobfuru
Copy link
Contributor

bobfuru commented Oct 2, 2020

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@bobfuru: new pull request created: #26086

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants