-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OCPRHV-391 Add not tested/not supported notice to OCP 4.6 and RHV 4.3 docs [enterprise-4.6][enterprise-4.5][enterprise-4.4] #25821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPRHV-391 Add not tested/not supported notice to OCP 4.6 and RHV 4.3 docs [enterprise-4.6][enterprise-4.5][enterprise-4.4] #25821
Conversation
sandrobonazzola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
New changes are detected. LGTM label has been removed. |
pneedle-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rolfedh I have now completed my peer review for this PR. Please let me know if you have any questions about my suggestions.
Can you please also confirm which OCP releases this PR relates to? Is this just for master and branch/enterprise-4.6? Thanks!
|
/cherrypick enterprise-4.4 |
|
@pneedle-rh: #25821 failed to apply on top of branch "enterprise-4.4": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.5 |
|
@pneedle-rh: new pull request created: #26109 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.6 |
|
@pneedle-rh: #25821 failed to apply on top of branch "enterprise-4.6": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rolfedh I have merged this PR to master and the openshift-cherrypick-robot successfully created a CP PR for 4.5, which I have just merged. However, there were several merge conflicts when trying to cherry pick to 4.4 and 4.6.
Please can you do the following?:
Thank you! |
|
I'm stuck. @pneedle-rh I don't have privileges to push (cherry picked) changes to enterprise-4.x branches. (Or I just don't know how to do this.) Can you give me some advice or direct me to someone for help? |
@rolfedh thank you for setting up a call. I look forward to discussing this with you later today. |
|
@pneedle-rh @rolfedh It appears that Paul's requests in #25821 (comment) never got implemented, is that true? Do you still plan to CP to 4.4 and 4.6? I have a PR to remove the second note from the OKD docs (which isn't really needed as the entire topic isn't in OKD). |
|
Thanks, Michael. I'll take care of it.
…On Thu, Feb 4, 2021 at 3:06 PM Michael Burke ***@***.***> wrote:
@pneedle-rh <https://github.com/pneedle-rh> @rolfedh
<https://github.com/rolfedh> It appears that Paul's requests in #25821
(comment)
<#25821 (comment)>
never got implemented, is that true? Do you still plan to CP to 4.4 and 4.6?
If so, can you CP to 4.7 also?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25821 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVVO5IEBDQKASKS5MDPEDS5L44XANCNFSM4R3S23IQ>
.
--
Rolfe Dlugy-Hegwer
Senior Technical Writer, US ENG Content Services
Red Hat North Carolina <https://www.redhat.com/>
[email protected]
M: 910-409-8007 IM: rdlugyhe
<https://red.ht/sig>To book a meeting with me, click here.
<https://calendly.com/rolfe-at-redhat>
|
|
@rolfedh I should imagine that the same merge conflict will arise for 4.7 as was seen for 4.6. As per my earlier comment for 4.6, I think it will be necessary to manually cherry pick for 4.7 (as well as 4.4 and 4.6) and resolve the points that I outlined. Please let me know if you would like to run through this on a screen share. |
|
This customer story has been addressed in 4.7 by #29364 |
https://issues.redhat.com/browse/OCPRHV-391