Skip to content

Add note about restrictions svc of LB type with Kuryr #25508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxwelldb merged 2 commits into from
Sep 21, 2020
Merged

Add note about restrictions svc of LB type with Kuryr #25508

maxwelldb merged 2 commits into from
Sep 21, 2020

Conversation

@MaysaMacedo
Copy link
Contributor

@MaysaMacedo MaysaMacedo commented Sep 16, 2020

When Kuryr is used creation of Services with Load Balancer type
are restricted to when a Router and External Connectivity exists
on the Cluster.

@MaysaMacedo MaysaMacedo changed the title Add note about restrictions with svc of LB type Add note about restrictions with svc of LB type with Kuryr Sep 16, 2020
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2020
@MaysaMacedo MaysaMacedo changed the title Add note about restrictions with svc of LB type with Kuryr Add note about restrictions svc of LB type with Kuryr Sep 16, 2020
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 16, 2020

/cc @luis5tb

@luis5tb
Copy link
Contributor

luis5tb commented Sep 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2020
maxwelldb
maxwelldb requested changes Sep 16, 2020
View reviewed changes
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 16, 2020

New changes are detected. LGTM label has been removed.

maxwelldb
maxwelldb requested changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on this edit?

modules/installation-osp-kuryr-known-limitations.adoc Outdated
Copy link
Contributor

@maxwelldb maxwelldb Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if the Machines Subnet is not connected to a Router or it’s connected, but the Router has no external gateway set, Kuryr won’t create Floating IPs for Services with LoadBalancer type.

->

[line break]
If the machines subnet is not connected to a router, or if the subnet is connected, but the router has no external gateway set, Kuryr cannot create floating IPs for load balancer services.

Copy link
Contributor Author

@MaysaMacedo MaysaMacedo Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Copy link
Contributor Author

@MaysaMacedo MaysaMacedo Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified "load balancer services" to "LoadBalancer services" to give a better indication that it's the type of the Service.

Copy link
Contributor

@maxwelldb maxwelldb Sep 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[line break]
If the machines subnet is not connected to a router, or if the subnet is connected, but the router has no external gateway set, Kuryr cannot create floating IPs for LoadBalancer services.

That, then? @MaysaMacedo

Copy link
Contributor

@maxwelldb maxwelldb Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committing directly.

@maxwelldb
Copy link
Contributor

maxwelldb commented Sep 18, 2020

Which versions should this apply to?

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 21, 2020

Which versions should this apply to?

4.6

@MaysaMacedo
Add note about restrictions with svc of LB type
76ed14e 
When Kuryr is used creation of Services with Load Balancer type
are restricted to when a Router and External Connectivity exists
on the Cluster.
@maxwelldb
Copy link
Contributor

maxwelldb commented Sep 21, 2020

@MaysaMacedo https://github.com/openshift/openshift-docs/pull/25508/files#diff-b6143035dd5fcf10335d556668c5a745

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 21, 2020 •
edited
Loading

Looks good @maxwelldb . Thanks!

@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 21, 2020
@maxwelldb
Copy link
Contributor

maxwelldb commented Sep 21, 2020

@MaysaMacedo TY! Do you have anyone from QE who's familiar with this and could +1 it?

@maxwelldb maxwelldb self-requested a review September 21, 2020 13:50
@eurijon
Copy link

eurijon commented Sep 21, 2020

It looks good from QE side!

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 21, 2020

It looks good from QE side!

Thanks, Jon.

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 21, 2020
@ahardin-rh ahardin-rh added this to the Future Release milestone Sep 21, 2020
@ahardin-rh
Copy link
Contributor

ahardin-rh commented Sep 21, 2020

LGTM! You just need to squash the two commits down into one. Thanks!

@maxwelldb
Copy link
Contributor

maxwelldb commented Sep 21, 2020

Thanks!

@maxwelldb maxwelldb merged commit c4219f1 into openshift:master Sep 21, 2020
@maxwelldb
Copy link
Contributor

maxwelldb commented Sep 21, 2020

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 21, 2020

@maxwelldb: new pull request created: #25623

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxwelldb maxwelldb maxwelldb approved these changes

@luis5tb luis5tb Awaiting requested review from luis5tb

Assignees

@luis5tb luis5tb

@MaysaMacedo MaysaMacedo

@maxwelldb maxwelldb

Labels

branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.6 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@MaysaMacedo @luis5tb @openshift-ci-robot @maxwelldb @eurijon @ahardin-rh @openshift-cherrypick-robot @vikram-redhat