RHOSP bare metal worker support - OSDOCS-1276 #25167

maxwelldb · 2020-09-01T18:48:34Z

https://issues.redhat.com/projects/OSDOCS/issues/OSDOCS-1276

modules/installation-osp-adding-bare-metal.adoc

openshift-docs-preview-bot · 2020-09-01T18:51:18Z

The preview will be available shortly at:

https://osp-ironic-osdocs1276--ocpdocs.netlify.com/

modules/installation-osp-adding-bare-metal.adoc

modules/installation-osp-deploying-bare-metal-preexisting.adoc

maxwelldb · 2020-09-01T18:56:25Z

@pierreprinetti Feel free to skim this. I haven't added anything to assemblies, yet, but each module should stand as a discrete task.

maxwelldb · 2020-09-11T18:00:10Z

@pierreprinetti Drafts for review:

I believe all of my previous comments/questions--even on Outdated files--are still valid.

maxwelldb · 2020-09-18T14:18:11Z

Added @mandre based on upstream docs blame. :)

maxwelldb · 2020-10-01T15:44:29Z

Change coming: openshift/installer#4230

maxwelldb · 2020-10-02T13:34:00Z

~~Updates in progress.~~

maxwelldb · 2020-10-02T19:11:52Z

Made a best guess at new content following openshift/installer#4230.

UPI: https://osp-ironic-osdocs1276--ocpdocs.netlify.app/openshift-enterprise/latest/installing/installing_openstack/installing-openstack-user.html#installation-osp-deploying-all-bare-metal-preexisting_installing-openstack-user
UPI (just compute machines): https://osp-ironic-osdocs1276--ocpdocs.netlify.app/openshift-enterprise/latest/installing/installing_openstack/installing-openstack-user.html#installation-osp-deploying-bare-metal-preexisting_installing-openstack-user
IPI: https://osp-ironic-osdocs1276--ocpdocs.netlify.app/openshift-enterprise/latest/installing/installing_openstack/installing-openstack-installer-custom.html#installation-osp-deploying-bare-metal_installing-openstack-installer-custom

modules/installation-osp-deploying-all-bare-metal-preexisting.adoc

modules/installation-osp-deploying-bare-metal-preexisting.adoc

mandre

~~Looks good to me.~~ Hold on, I just noticed something.

mandre · 2020-10-07T10:26:41Z

installing/installing_openstack/installing-openstack-user.adoc

These two modules aren't specific to UPI, they're also relevant to IPI with custom subnet.

mandre · 2020-10-07T10:27:22Z

installing/installing_openstack/installing-openstack-installer-custom.adoc

This module also applies to UPI.

@mandre Just woke up, but does that mean that the "installer-provisioned network" description would need to go, then?

@mandre And is the example YAML in it appropriate for both IPI and UPI?

Actually, the flavors set in the install-config.yaml files aren't used in UPI. We need to modify the os_flavor_master and os_flavor_worker ansible variables in the inventory.yaml file in the UPI case.

maxwelldb · 2020-10-07T14:21:00Z

@mandre See be98086

Previews should rebuild shortly.

maxwelldb · 2020-10-19T14:36:40Z

Removing 4.6 label. Will be included in TBD release.

/hold

udis · 2021-02-01T12:04:01Z

@maxwelldb Looks good. I would add a note about FIP and FIPless options which can have an effect on the install-config.yaml example.

maxwelldb · 2021-02-01T13:41:56Z

@udis Do you have something more concrete that you'd like to see there? This has been low-touch for me since October, of course. :)

udis

FIP vs FIPless note based on openstack baremetal network

modules/installation-osp-deploying-bare-metal-machines.adoc

netlify · 2021-02-04T16:19:00Z

Deploy preview for osdocs ready!

Built with commit 2a9d8c6

https://deploy-preview-25167--osdocs.netlify.app

modules/installation-osp-deploying-bare-metal-machines.adoc

modules/machineset-osp-adding-bare-metal.adoc

jboxman

Left some comments for your review. Thanks!

modules/installation-osp-deploying-bare-metal-machines.adoc

maxwelldb · 2021-02-10T18:45:33Z

/cherry-pick enterprise-4.7

openshift-cherrypick-robot · 2021-02-10T18:46:17Z

@maxwelldb: new pull request created: #29377

Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maxwelldb added the branch/enterprise-4.6 label Sep 1, 2020

maxwelldb added this to the Future Release milestone Sep 1, 2020

maxwelldb self-assigned this Sep 1, 2020

maxwelldb commented Sep 1, 2020

View reviewed changes

modules/installation-osp-adding-bare-metal.adoc Outdated Show resolved Hide resolved

maxwelldb commented Sep 1, 2020

View reviewed changes

modules/installation-osp-adding-bare-metal.adoc Outdated Show resolved Hide resolved

maxwelldb commented Sep 1, 2020

View reviewed changes

modules/installation-osp-deploying-bare-metal-preexisting.adoc Outdated Show resolved Hide resolved

maxwelldb requested a review from pierreprinetti September 9, 2020 17:57

maxwelldb force-pushed the osp-ironic-osdocs1276 branch from a16a424 to 41f0afc Compare September 11, 2020 17:40

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2020

maxwelldb force-pushed the osp-ironic-osdocs1276 branch 2 times, most recently from 504d6dc to 895dee3 Compare September 11, 2020 17:53

maxwelldb marked this pull request as ready for review September 16, 2020 18:33

maxwelldb requested a review from mandre September 18, 2020 14:18

maxwelldb force-pushed the osp-ironic-osdocs1276 branch from 666a75f to 33893d9 Compare October 2, 2020 18:22

pierreprinetti reviewed Oct 5, 2020

View reviewed changes

modules/installation-osp-deploying-all-bare-metal-preexisting.adoc Outdated Show resolved Hide resolved

maxwelldb requested a review from pierreprinetti October 5, 2020 13:30

mandre reviewed Oct 6, 2020

View reviewed changes

maxwelldb requested a review from mandre October 6, 2020 15:18

mandre reviewed Oct 7, 2020

View reviewed changes

maxwelldb requested a review from mandre October 7, 2020 14:21

maxwelldb removed the branch/enterprise-4.6 label Oct 19, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2020

maxwelldb added branch/enterprise-4.7 and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 17, 2020

maxwelldb requested a review from udis January 16, 2021 13:36

udis reviewed Feb 4, 2021

View reviewed changes

modules/installation-osp-deploying-bare-metal-machines.adoc Outdated Show resolved Hide resolved

maxwelldb commented Feb 4, 2021

View reviewed changes

modules/installation-osp-deploying-bare-metal-machines.adoc Outdated Show resolved Hide resolved

maxwelldb removed the request for review from morenod February 4, 2021 16:15

maxwelldb commented Feb 4, 2021

View reviewed changes

modules/installation-osp-deploying-bare-metal-machines.adoc Outdated Show resolved Hide resolved

maxwelldb commented Feb 7, 2021

View reviewed changes

modules/machineset-osp-adding-bare-metal.adoc Outdated Show resolved Hide resolved

maxwelldb commented Feb 7, 2021

View reviewed changes

modules/machineset-osp-adding-bare-metal.adoc Outdated Show resolved Hide resolved

maxwelldb commented Feb 7, 2021

View reviewed changes

modules/machineset-osp-adding-bare-metal.adoc Outdated Show resolved Hide resolved

maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 8, 2021

maxwelldb requested a review from jboxman February 8, 2021 20:31

jboxman reviewed Feb 9, 2021

View reviewed changes

jboxman added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 9, 2021

maxwelldb force-pushed the osp-ironic-osdocs1276 branch from 361b5c8 to 8e7eb46 Compare February 10, 2021 18:34

Bare metal workers for ShiftStack

2a9d8c6

maxwelldb force-pushed the osp-ironic-osdocs1276 branch from 8e7eb46 to 2a9d8c6 Compare February 10, 2021 18:39

maxwelldb merged commit c120fd1 into openshift:master Feb 10, 2021

openshift-cherrypick-robot mentioned this pull request Feb 10, 2021

[enterprise-4.7] RHOSP bare metal worker support - OSDOCS-1276 #29377

Merged

vikram-redhat modified the milestones: Future Release, OCP 4.7 GA Feb 24, 2021

RHOSP bare metal worker support - OSDOCS-1276 #25167

RHOSP bare metal worker support - OSDOCS-1276 #25167

Uh oh!

Conversation

maxwelldb commented Sep 1, 2020

Uh oh!

Uh oh!

openshift-docs-preview-bot commented Sep 1, 2020

Uh oh!

Uh oh!

Uh oh!

maxwelldb commented Sep 1, 2020

Uh oh!

maxwelldb commented Sep 11, 2020

Uh oh!

maxwelldb commented Sep 18, 2020

Uh oh!

maxwelldb commented Oct 1, 2020

Uh oh!

maxwelldb commented Oct 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxwelldb commented Oct 2, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mandre left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mandre Oct 7, 2020

Choose a reason for hiding this comment

Uh oh!

mandre Oct 7, 2020

Choose a reason for hiding this comment

Uh oh!

maxwelldb Oct 7, 2020

Choose a reason for hiding this comment

Uh oh!

maxwelldb Oct 7, 2020

Choose a reason for hiding this comment

Uh oh!

mandre Oct 9, 2020

Choose a reason for hiding this comment

Uh oh!

maxwelldb commented Oct 7, 2020

Uh oh!

maxwelldb commented Oct 19, 2020

Uh oh!

udis commented Feb 1, 2021

Uh oh!

maxwelldb commented Feb 1, 2021

Uh oh!

udis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jboxman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxwelldb commented Oct 2, 2020 •

edited

Loading

mandre left a comment •

edited

Loading

netlify bot commented Feb 4, 2021 •

edited

Loading