Skip to content

Conversation

@luis5tb
Copy link
Contributor

@luis5tb luis5tb commented Aug 31, 2020

Wrong tagging of compute node parent ports make kuryr not able
to find the precreated ports, thus breaking the kuryr ports pool
functionality

Wrong tagging of compute node parent ports make kuryr not able
to find the precreated ports, thus breaking the kuryr ports pool
functionality
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 31, 2020
@openshift-ci-robot
Copy link

@luis5tb: This pull request references Bugzilla bug 1873448, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1873448: Ensure proper tagging of compute node ports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2020
@MaysaMacedo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@pierreprinetti
Copy link
Member

/lgtm

Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eurijon
Copy link

eurijon commented Aug 31, 2020

@luis5tb Looks fine to me.

@eurijon Are you able to verify this docs change? Preview @ http://file.rdu.redhat.com/mbridges/31Aug2020/tagging/installing/installing_openstack/installing-openstack-user.html#installation-osp-creating-compute-machines_installing-openstack-user

It looks good to me, note it's needed in both Kuryr and non-Kuryr use cases, and 4.4 and 4.5 versions.

Thanks!

@maxwelldb
Copy link
Contributor

@eurijon TY! That module is used in both UPI assemblies, so the change will be reflected in both Kuryr and non-Kuryr contexts.

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 31, 2020
Copy link
Contributor

@lbarbeevargas lbarbeevargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbarbeevargas lbarbeevargas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 31, 2020
@maxwelldb
Copy link
Contributor

@lbarbeevargas Thanks!

@maxwelldb maxwelldb merged commit 91754dd into openshift:master Aug 31, 2020
@openshift-ci-robot
Copy link

@luis5tb: All pull requests linked via external trackers have merged:

Bugzilla bug 1873448 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1873448: Ensure proper tagging of compute node ports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb
Copy link
Contributor

/cherry-pick enterprise-4.4

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #25141

Details

In response to this:

/cherry-pick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb
Copy link
Contributor

/cherry-pick enterprise-4.5

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #25142

Details

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb
Copy link
Contributor

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #25143

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants