-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Bug 1873448: Ensure proper tagging of compute node ports #25137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wrong tagging of compute node parent ports make kuryr not able to find the precreated ports, thus breaking the kuryr ports pool functionality
|
@luis5tb: This pull request references Bugzilla bug 1873448, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/lgtm |
maxwelldb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luis5tb Looks fine to me.
@eurijon Are you able to verify this docs change? Preview @ http://file.rdu.redhat.com/mbridges/31Aug2020/tagging/installing/installing_openstack/installing-openstack-user.html#installation-osp-creating-compute-machines_installing-openstack-user
It looks good to me, note it's needed in both Kuryr and non-Kuryr use cases, and 4.4 and 4.5 versions. Thanks! |
|
New changes are detected. LGTM label has been removed. |
lbarbeevargas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@lbarbeevargas Thanks! |
|
@luis5tb: All pull requests linked via external trackers have merged: Bugzilla bug 1873448 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.4 |
|
@maxwelldb: new pull request created: #25141 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.5 |
|
@maxwelldb: new pull request created: #25142 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.6 |
|
@maxwelldb: new pull request created: #25143 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Wrong tagging of compute node parent ports make kuryr not able
to find the precreated ports, thus breaking the kuryr ports pool
functionality