Skip to content

Conversation

@kalexand-rh
Copy link
Contributor

Per #21993 (comment) and #23615 (review), the disconnected update method should work in 4.3, as long as you manually create the configmap.

@jianlinliu, will you PTAL when you have a chance?

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because 4.3 does not support --apply-release-image-signature when mirror images, so the mirror registry's host does not need to be connected to clutser. So here suggest:
If the local container registry is connected to the mirror registry's host, you can directly push the release images to the local registry.

Copy link

@jianlinliu jianlinliu Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:
If the local container registry is connected to the mirror host, directly push the release images to the local registry by using following command:

@kalexand-rh kalexand-rh force-pushed the disconnected_update_+4.3 branch from b511d6e to 8743220 Compare August 27, 2020 17:25
@kalexand-rh
Copy link
Contributor Author

Thank you @jianlinliu! I've incorporated both of your suggestions. Please let me know if you see any other changes or if this is ready to merge.

@jianlinliu
Copy link

jianlinliu commented Aug 28, 2020

Thank you @jianlinliu! I've incorporated both of your suggestions.

Hmm, why I did not see your change in https://github.com/openshift/openshift-docs/pull/24971/files?

@kalexand-rh kalexand-rh force-pushed the disconnected_update_+4.3 branch from 8743220 to 53ed595 Compare September 22, 2020 16:58
@kalexand-rh
Copy link
Contributor Author

@jianlinliu, my apologies for the delay. Will you PTAL?

@openshift-docs-preview-bot

The preview will be available shortly at:

  • https://disconnected_update_+4.3--ocpdocs.netlify.com/

@jianlinliu
Copy link

LGTM.

@kalexand-rh kalexand-rh force-pushed the disconnected_update_+4.3 branch from 53ed595 to 64c0d1f Compare September 23, 2020 13:48
@kalexand-rh kalexand-rh merged commit c64c157 into openshift:enterprise-4.3 Sep 23, 2020
@kalexand-rh kalexand-rh deleted the disconnected_update_+4.3 branch September 23, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants