-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Disconnected update method for 4.3 #24971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disconnected update method for 4.3 #24971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because 4.3 does not support --apply-release-image-signature when mirror images, so the mirror registry's host does not need to be connected to clutser. So here suggest:
If the local container registry is connected to the mirror registry's host, you can directly push the release images to the local registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
If the local container registry is connected to the mirror host, directly push the release images to the local registry by using following command:
b511d6e to
8743220
Compare
|
Thank you @jianlinliu! I've incorporated both of your suggestions. Please let me know if you see any other changes or if this is ready to merge. |
Hmm, why I did not see your change in https://github.com/openshift/openshift-docs/pull/24971/files? |
8743220 to
53ed595
Compare
|
@jianlinliu, my apologies for the delay. Will you PTAL? |
|
The preview will be available shortly at:
|
|
LGTM. |
53ed595 to
64c0d1f
Compare
Per #21993 (comment) and #23615 (review), the disconnected update method should work in 4.3, as long as you manually create the configmap.
@jianlinliu, will you PTAL when you have a chance?