Add PushSecretName documentation #248
Conversation
|
@bparees @soltysh @CowboysFan PTAL (do not merge this till openshift/origin#1411 lands) |
architecture/builds.adoc
Outdated
There was a problem hiding this comment.
this is an encrypted password, not plaintext, right? might clarify that so someone doesn't try to create one from scratch.
architecture/builds.adoc
Outdated
There was a problem hiding this comment.
k8s provides the Secret resource which you can use to.....
architecture/builds.adoc
Outdated
There was a problem hiding this comment.
no longer true w/ your other PR.
|
@bparees @soltysh @CowboysFan all comments addressed, thanks! Also openshift/origin#1411 is pushed so I think this is good to go. |
architecture/builds.adoc
Outdated
There was a problem hiding this comment.
I'd propose writing: If it does not exist execute docker login to have it created.
There was a problem hiding this comment.
@soltysh if it exists then you can use this command to add multiple entries to the file. I think the current text is ok.
There was a problem hiding this comment.
"You can also add authentication entries to this file by running.... the file will be created if it does not exist"
|
One more nit, you're using dockercfg and .dockercfg interchangeably is it intentional? IMHO it'd be better to have one name used all over the text. |
|
@soltysh that is intentional, the filename is in fact |
architecture/builds.adoc
Outdated
There was a problem hiding this comment.
Based on your last comment this should be .dockercfg then.
mfojtik
force-pushed
the
build_config
branch
3 times, most recently
from
3788f21 to
e9b575c
Compare
|
LGTM |
|
@mfojtik +1 on using "dockercfg" as the key. |
|
@bparees fixed last comment :-) |
|
lgtm. :) |
|
@mfojtik I've reviewed (FYI @CowboysFan) since I've got the related docs card (https://trello.com/c/XWNfqLAC). Thanks, and merging. Will follow up per docs card. |
Add PushSecretName documentation
WINDUP-2269: Updated windupVersion description.
4 participants
No description provided.