Skip to content

BZ1850510 - Update NFS registry storage docs #24276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bobfuru merged 1 commit into from
Aug 4, 2020
Merged

BZ1850510 - Update NFS registry storage docs #24276

bobfuru merged 1 commit into from
Aug 4, 2020

Conversation

@bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Jul 28, 2020 •
edited
Loading

BZ1850510 - Add link to Group IDs module for recommended info about using supplemental groups for NFS shared storage. And also update NFS example to use root_squash and no_wdelay. Applies to OCP 4.3+.

Preview links - step 2 note and example now include root_squash and supplemental group note is added in step 1:

@bobfuru bobfuru added this to the Next Release milestone Jul 28, 2020
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2020
@bobfuru bobfuru force-pushed the BZ1850510 branch 3 times, most recently from b4087b2 to 42018d7 Compare July 29, 2020 20:41
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Jul 29, 2020

The preview will be available shortly at:

@bobfuru bobfuru force-pushed the BZ1850510 branch 2 times, most recently from 1c36bc7 to 2e22562 Compare July 29, 2020 21:06
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Jul 29, 2020

@huffmanca - PTAL and let me know if this approach makes sense to you. Still not able to add xrefs within the module itself, so the best solution seemed to add the supplementalGroups info at the end of the bare metal reg config procedure as an important note. I've also added root_squash in step 2 for NFS. Thanks!

huffmanca
huffmanca reviewed Jul 30, 2020
View reviewed changes
Copy link
Contributor

@huffmanca huffmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, but I do have a couple of suggestions and nitpicks.

In addition, while this addresses the issues in the baremetal assembly, we need to make identical changes to the vsphere assembly as well.

@bobfuru
Copy link
Contributor Author

bobfuru commented Jul 30, 2020 •
edited
Loading

Thanks, @huffmanca! Changes made, and I've also added the note to the vSphere assembly. Could you please take a second look?

@bobfuru bobfuru force-pushed the BZ1850510 branch 2 times, most recently from c0c9de8 to d05031c Compare July 30, 2020 19:27
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2020
@huffmanca
Copy link
Contributor

huffmanca commented Jul 30, 2020

Thanks for these changes!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Jul 30, 2020

@qinpingli - PTAL for QE review.

@bobfuru
Copy link
Contributor Author

bobfuru commented Jul 30, 2020

@openshift/team-documentation PTAL

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 30, 2020
@ahardin-rh
Copy link
Contributor

ahardin-rh commented Jul 30, 2020

LGTM 👍

qinpingli
qinpingli reviewed Jul 31, 2020
View reviewed changes
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2020

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@bobfuru bobfuru force-pushed the BZ1850510 branch 3 times, most recently from 9a24af8 to acba120 Compare July 31, 2020 18:46
@qinpingli
Copy link

qinpingli commented Aug 3, 2020

@bobfuru Thanks for the update.

Now the patch lgtm.

bobfuru
bobfuru commented Aug 3, 2020
View reviewed changes
@bobfuru bobfuru merged commit 788ed2c into openshift:master Aug 4, 2020
@bobfuru bobfuru deleted the BZ1850510 branch August 4, 2020 21:05
@bobfuru bobfuru restored the BZ1850510 branch August 4, 2020 21:05
@bobfuru
Copy link
Contributor Author

bobfuru commented Aug 4, 2020

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 4, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 4, 2020

@bobfuru: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/openshift-docs\n ! [remote rejected] cherry-pick-24276-to-enterprise-4.6 -> cherry-pick-24276-to-enterprise-4.6 (cannot lock ref 'refs/heads/cherry-pick-24276-to-enterprise-4.6': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:[email protected]/openshift-cherrypick-robot/openshift-docs'\n", error: exit status 1

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 4, 2020

@bobfuru: new pull request created: #24458

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru
Copy link
Contributor Author

bobfuru commented Aug 4, 2020

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 4, 2020

@bobfuru: #24276 failed to apply on top of branch "enterprise-4.5":

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru
Copy link
Contributor Author

bobfuru commented Aug 4, 2020

/cherrypick enterprise-4.4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 4, 2020

@bobfuru: #24276 failed to apply on top of branch "enterprise-4.4":

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru
Copy link
Contributor Author

bobfuru commented Aug 4, 2020

/cherrypick enterprise-4.3

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 4, 2020

@bobfuru: #24276 failed to apply on top of branch "enterprise-4.3":

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 4, 2020
Merged
Merged
Merged
bobfuru pushed a commit to bobfuru/openshift-docs that referenced this pull request Aug 5, 2020
Cherry Picked 788ed2c from openshift#24276 on 4-5
348b7c1
@bobfuru bobfuru mentioned this pull request Aug 5, 2020
Merged
bobfuru pushed a commit that referenced this pull request Aug 5, 2020
Merge pull request #24493 from bobfuru/BZ1850510-4-5
ef49ebe 
Cherry Picked 788ed2c from #24276 on 4-5
@bobfuru bobfuru mentioned this pull request Aug 13, 2020
Closed
@bobfuru bobfuru mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@huffmanca huffmanca huffmanca left review comments

@qinpingli qinpingli qinpingli left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@huffmanca huffmanca

Labels

branch/enterprise-4.3 branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@bobfuru @openshift-docs-preview-bot @huffmanca @ahardin-rh @openshift-ci-robot @qinpingli @openshift-cherrypick-robot