Update container catalog terminology #24205

bmcelvee · 2020-07-27T15:22:18Z

This PR is intended to update the appropriate Red Hat Container Catalog terminology to reflect the change to Red Hat Ecosystem Catalog.

Previews:
https://deploy-preview-24205--osdocs.netlify.app/openshift-enterprise/latest/architecture/understanding-development.html
https://deploy-preview-24205--osdocs.netlify.app/openshift-enterprise/latest/registry/registry-options.html
https://deploy-preview-24205--osdocs.netlify.app/openshift-enterprise/latest/security/container_security/security-container-content.html
https://deploy-preview-24205--osdocs.netlify.app/openshift-enterprise/latest/security/container_security/security-registries.html
https://deploy-preview-24205--osdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virt-installing-virtio-drivers-on-existing-windows-vm.html
https://deploy-preview-24205--osdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virt-installing-virtio-drivers-on-new-windows-vm.html
https://deploy-preview-24205--osdocs.netlify.app/openshift-enterprise/latest/openshift_images/using_images/using-images-overview.html

This is a terminology update only. No QE review required.

openshift-docs-preview-bot · 2020-07-27T15:24:45Z

The preview will be available shortly at:

https://update-catalog-term--ocpdocs.netlify.com/

bmcelvee · 2020-07-27T20:31:23Z

Planning to add an assembly or module to describe the Red Hat Ecosystem Catalog.

jboxman · 2020-08-04T04:12:54Z

@bmcelvee do we capitalize Container and Image when not referring to API objects? In the wild, it's rare to see container capitalized.

bmcelvee · 2020-08-04T14:43:11Z

@jboxman depends on the circumstance. Since we're referring to a title here, Container does need to be capitalized. But as it turns out image doesn't, so I'll update the PR to reflect that. Thanks!

openshift-bot · 2020-11-02T19:43:58Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2020-12-02T21:40:24Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2021-01-01T23:29:40Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot · 2021-01-01T23:29:55Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bergerhoffer · 2021-02-01T16:50:52Z

@bmcelvee This came up in a discussion for the supplementary style guide here: redhat-documentation/supplementary-style-guide#53

Should we reopen this PR to get the terminology fixed?

bergerhoffer · 2021-02-01T16:54:12Z

architecture/understanding-development.adoc

If we do reopen this PR for inclusion, "Container Images" should be "Container images" throughout the PR.

Hi! Yes, I'll reopen this PR. Thank you for that note.

Thanks a lot @bmcelvee!

bergerhoffer · 2021-03-09T14:49:11Z

@bmcelvee I'm reopening this PR just so that it doesn't get lost. Let me know if you want me to take it over to get it wrapped up. Thanks!

netlify · 2021-03-17T19:38:16Z

Deploy preview for osdocs ready!

Built with commit 74cd1d4

https://deploy-preview-24205--osdocs.netlify.app

bmcelvee · 2021-03-17T19:45:59Z

@bmcelvee I'm reopening this PR just so that it doesn't get lost. Let me know if you want me to take it over to get it wrapped up. Thanks!

Thanks, @bergerhoffer! Found and updated the remaining references to Red Hat Container Catalog.

codyhoag

One question; looks good otherwise!

codyhoag · 2021-03-17T20:03:11Z

modules/installation-obtaining-installer.adoc

Should this link follow the other changes and point to https://catalog.redhat.com/software/containers/explore?

That's a good question. registry.redhat.io redirects to https://catalog.redhat.com/software/containers/explore. I can go ahead and change those, but I think I'll need to open a CIT issue to change registry.redhat.io links to https://catalog.redhat.com/software/containers/explore in other files because there are a lot of independent references and links to the registry.redhat.io URL.

bmcelvee · 2021-03-17T20:49:17Z

/cherrypick enterprise-4.5

bmcelvee · 2021-03-17T20:49:22Z

/cherrypick enterprise-4.6

bmcelvee · 2021-03-17T20:49:28Z

/cherrypick enterprise-4.7

bmcelvee · 2021-03-17T20:49:33Z

/cherrypick enterprise-4.8

openshift-cherrypick-robot · 2021-03-17T20:49:54Z

@bmcelvee: #24205 failed to apply on top of branch "enterprise-4.5":

Applying: Update container catalog terminology
Using index info to reconstruct a base tree...
M	architecture/understanding-development.adoc
M	modules/installation-obtaining-installer.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-obtaining-installer.adoc
CONFLICT (content): Merge conflict in modules/installation-obtaining-installer.adoc
Auto-merging architecture/understanding-development.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update container catalog terminology
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-03-17T20:49:58Z

@bmcelvee: #24205 failed to apply on top of branch "enterprise-4.6":

Applying: Update container catalog terminology
Using index info to reconstruct a base tree...
M	architecture/understanding-development.adoc
M	modules/installation-obtaining-installer.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-obtaining-installer.adoc
CONFLICT (content): Merge conflict in modules/installation-obtaining-installer.adoc
Auto-merging architecture/understanding-development.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update container catalog terminology
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-03-17T20:50:05Z

@bmcelvee: #24205 failed to apply on top of branch "enterprise-4.7":

Applying: Update container catalog terminology
Using index info to reconstruct a base tree...
M	modules/installation-obtaining-installer.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-obtaining-installer.adoc
CONFLICT (content): Merge conflict in modules/installation-obtaining-installer.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update container catalog terminology
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-03-17T20:50:09Z

@bmcelvee: #24205 failed to apply on top of branch "enterprise-4.8":

Applying: Update container catalog terminology
Using index info to reconstruct a base tree...
M	modules/installation-obtaining-installer.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-obtaining-installer.adoc
CONFLICT (content): Merge conflict in modules/installation-obtaining-installer.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update container catalog terminology
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2020

bmcelvee force-pushed the update-catalog-term branch from 9290213 to 822d162 Compare August 3, 2020 20:38

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 2, 2020

openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 2, 2020

openshift-ci-robot closed this Jan 1, 2021

bergerhoffer reviewed Feb 1, 2021

View reviewed changes

bergerhoffer mentioned this pull request Feb 1, 2021

Red Hat Container Catalog is no more redhat-documentation/supplementary-style-guide#53

Closed

bergerhoffer reopened this Mar 9, 2021

bmcelvee force-pushed the update-catalog-term branch from 822d162 to bb3d12b Compare March 17, 2021 19:36

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2021

bmcelvee force-pushed the update-catalog-term branch from bb3d12b to 47ea8b6 Compare March 17, 2021 19:42

bmcelvee changed the title ~~[WIP] Update container catalog terminology~~ Update container catalog terminology Mar 17, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2021

bmcelvee added branch/enterprise-4.5 branch/enterprise-4.6 and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Mar 17, 2021

bmcelvee added branch/enterprise-4.7 branch/enterprise-4.8 labels Mar 17, 2021

bmcelvee added this to the Next Release milestone Mar 17, 2021

bmcelvee added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 17, 2021

codyhoag reviewed Mar 17, 2021

View reviewed changes

codyhoag added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 17, 2021

Update container catalog terminology

74cd1d4

bmcelvee force-pushed the update-catalog-term branch from 47ea8b6 to 74cd1d4 Compare March 17, 2021 20:43

bmcelvee merged commit 9849604 into openshift:master Mar 17, 2021

Update container catalog terminology #24205

Update container catalog terminology #24205

Uh oh!

Conversation

bmcelvee commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-docs-preview-bot commented Jul 27, 2020

Uh oh!

bmcelvee commented Jul 27, 2020

Uh oh!

jboxman commented Aug 4, 2020

Uh oh!

bmcelvee commented Aug 4, 2020

Uh oh!

openshift-bot commented Nov 2, 2020

Uh oh!

openshift-bot commented Dec 2, 2020

Uh oh!

openshift-bot commented Jan 1, 2021

Uh oh!

openshift-ci-robot commented Jan 1, 2021

Uh oh!

bergerhoffer commented Feb 1, 2021

Uh oh!

bergerhoffer Feb 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bmcelvee Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

bergerhoffer Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

bergerhoffer commented Mar 9, 2021

Uh oh!

netlify bot commented Mar 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bmcelvee commented Mar 17, 2021

Uh oh!

codyhoag left a comment

Choose a reason for hiding this comment

Uh oh!

codyhoag Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

bmcelvee Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

bmcelvee commented Mar 17, 2021

Uh oh!

bmcelvee commented Mar 17, 2021

Uh oh!

bmcelvee commented Mar 17, 2021

Uh oh!

bmcelvee commented Mar 17, 2021

Uh oh!

openshift-cherrypick-robot commented Mar 17, 2021

Uh oh!

openshift-cherrypick-robot commented Mar 17, 2021

Uh oh!

openshift-cherrypick-robot commented Mar 17, 2021

Uh oh!

openshift-cherrypick-robot commented Mar 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bmcelvee commented Jul 27, 2020 •

edited

Loading

bergerhoffer Feb 1, 2021 •

edited

Loading

netlify bot commented Mar 17, 2021 •

edited

Loading