-
Notifications
You must be signed in to change notification settings - Fork 1.9k
BZ-1854318 Fixed codeblock callout text #23951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The preview will be available shortly at: |
|
The same fix should also be applied for comment #8 in "Example: Bond interface NodeNetworkConfigurationPolicy" (https://bz-1854318--ocpdocs.netlify.app/openshift-enterprise/latest/virt/node_network/virt-updating-node-network-config.html#virt-example-bond-nncp_virt-updating-node-network-config) |
|
@yossisegev I have made the changes per your comment |
|
LGTM |
|
This LGTM, but I can only CP this to 4.5 because 4.4 contains our old naming structure. Please open a new PR directly against the 4.4 branch. Thanks, Shikha! |
|
/cherrypick enterprise-4.5 |
|
@ousleyp: new pull request created: #24084 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.6 |
|
@ousleyp: new pull request created: #24085 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ousleyp: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.5 and openshift-cherrypick-robot:cherry-pick-23951-to-enterprise-4.5"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
BZ-1854318 https://bugzilla.redhat.com/show_bug.cgi?id=1854318
Preview: https://bz-1854318--ocpdocs.netlify.app/openshift-enterprise/latest/virt/node_network/virt-updating-node-network-config.html#virt-example-bridge-nncp_virt-updating-node-network-config
Fixed text for codeblock callout <8> to remove the static IP address requirement for the interface
Applies to 4.5 docs