Skip to content

Conversation

@sjhala-ccs
Copy link
Contributor

@sjhala-ccs sjhala-ccs commented Jul 20, 2020

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 20, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@yossisegev
Copy link

The same fix should also be applied for comment #8 in "Example: Bond interface NodeNetworkConfigurationPolicy" (https://bz-1854318--ocpdocs.netlify.app/openshift-enterprise/latest/virt/node_network/virt-updating-node-network-config.html#virt-example-bond-nncp_virt-updating-node-network-config)

@sjhala-ccs
Copy link
Contributor Author

@yossisegev I have made the changes per your comment

@yossisegev
Copy link

LGTM

@ousleyp ousleyp added this to the Next Release milestone Jul 22, 2020
@ousleyp ousleyp added branch/enterprise-4.5 peer-review-done Signifies that the peer review team has reviewed this PR labels Jul 22, 2020
@ousleyp
Copy link
Member

ousleyp commented Jul 22, 2020

This LGTM, but I can only CP this to 4.5 because 4.4 contains our old naming structure. Please open a new PR directly against the 4.4 branch. Thanks, Shikha!

@ousleyp ousleyp merged commit c8f11b9 into openshift:master Jul 22, 2020
@ousleyp
Copy link
Member

ousleyp commented Jul 22, 2020

/cherrypick enterprise-4.5

@openshift-cherrypick-robot

@ousleyp: new pull request created: #24084

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ousleyp
Copy link
Member

ousleyp commented Jul 22, 2020

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@ousleyp: new pull request created: #24085

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ousleyp: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.5 and openshift-cherrypick-robot:cherry-pick-23951-to-enterprise-4.5"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants