-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add network customization for vSphere installer-provisioned #23589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network customization for vSphere installer-provisioned #23589
Conversation
6807783 to
72eeddc
Compare
|
@kalexand-rh, FYI. |
|
The preview will be available shortly at: |
|
This adds the requested network customizations; What do you think? Thanks! |
|
@==
Since in section of "Network configuration parameters', it describes each parameters under "networking", but in sample install-config.yaml does not describe this part. It's better to add them. Below is the install-config.yaml generated after running "openshift-install create install-config" and add customized platform under compute/controlPlane section |
72eeddc to
fa794ae
Compare
|
@jinyunma, I've updated the sample configuration. Thanks! |
|
@kalexand-rh, did I miss any conditionals for this? I'm less familiar with the installation modules. Thanks! |
|
thanks to update, lgtm. |
- Related to OSDOCS-988
fa794ae to
901cac5
Compare
|
@jboxman, the conditionals look ok to me - I'm not seeing any omissions. |
|
/cherry-pick enterprise-4.6 |
|
/cherry-pick enterprise-4.5 |
|
@jboxman: new pull request created: #23922 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jboxman: new pull request created: #23923 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Refs #22485.