Skip to content

Conversation

@jboxman
Copy link
Contributor

@jboxman jboxman commented Jul 9, 2020

  • Related to OSDOCS-988

Refs #22485.

@jboxman jboxman added this to the Future Release milestone Jul 9, 2020
@jboxman jboxman self-assigned this Jul 9, 2020
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2020
@jboxman jboxman force-pushed the vsphere-ipi-network-customization branch from 6807783 to 72eeddc Compare July 9, 2020 18:57
@jboxman
Copy link
Contributor Author

jboxman commented Jul 9, 2020

@kalexand-rh, FYI.

@openshift-docs-preview-bot

The preview will be available shortly at:

@jboxman
Copy link
Contributor Author

jboxman commented Jul 11, 2020

@jinyunma

This adds the requested network customizations; What do you think? Thanks!

@jinyunma
Copy link

jinyunma commented Jul 14, 2020

@==

@jinyunma

This adds the requested network customizations; What do you think? Thanks!

Since in section of "Network configuration parameters', it describes each parameters under "networking", but in sample install-config.yaml does not describe this part. It's better to add them. Below is the install-config.yaml generated after running "openshift-install create install-config" and add customized platform under compute/controlPlane section

apiVersion: v1
baseDomain: qe.devcluster.openshift.com
compute:
- architecture: amd64
  hyperthreading: Enabled
  name: worker
  platform: 
    vsphere: 
      cpus: 2
      coresPerSocket: 2
      memoryMB: 8196
      osDisk:
        diskSizeGB: 120
  replicas: 3
controlPlane:
  architecture: amd64
  hyperthreading: Enabled
  name: master
  platform:
    vsphere: 
      cpus: 4
      coresPerSocket: 2
      memoryMB: 16384
      osDisk:
        diskSizeGB: 120
  replicas: 3
metadata:
  creationTimestamp: null
  name: ipitest
networking:
  clusterNetwork:
  - cidr: 10.128.0.0/14
    hostPrefix: 23
  machineNetwork:
  - cidr: 10.0.0.0/16
  networkType: OpenShiftSDN
  serviceNetwork:
  - 172.30.0.0/16
platform:
  vsphere:
    apiVIP: 10.0.0.2
    cluster: devel
    datacenter: dc1
    defaultDatastore: nvme-ds1
    ingressVIP: 10.0.0.3
    network: VM Network
    password: 'xxxxxxx'
    username: xxxxxxx
    vCenter: vcsa-qe.vmware.devcluster.openshift.com
publish: External
pullSecret: xxxx
sshKey:  xxxxx

@jboxman jboxman force-pushed the vsphere-ipi-network-customization branch from 72eeddc to fa794ae Compare July 14, 2020 20:59
@jboxman
Copy link
Contributor Author

jboxman commented Jul 14, 2020

@jinyunma, I've updated the sample configuration.

Thanks!

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2020
@jboxman
Copy link
Contributor Author

jboxman commented Jul 14, 2020

@kalexand-rh, did I miss any conditionals for this? I'm less familiar with the installation modules.

Thanks!

@jinyunma
Copy link

thanks to update, lgtm.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2020
@jboxman jboxman force-pushed the vsphere-ipi-network-customization branch from fa794ae to 901cac5 Compare July 16, 2020 23:37
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2020
@kalexand-rh
Copy link
Contributor

@jboxman, the conditionals look ok to me - I'm not seeing any omissions.

@jboxman jboxman merged commit 4557452 into openshift:master Jul 17, 2020
@jboxman
Copy link
Contributor Author

jboxman commented Jul 17, 2020

/cherry-pick enterprise-4.6

@jboxman
Copy link
Contributor Author

jboxman commented Jul 17, 2020

/cherry-pick enterprise-4.5

@jboxman jboxman deleted the vsphere-ipi-network-customization branch July 17, 2020 17:58
@openshift-cherrypick-robot

@jboxman: new pull request created: #23922

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jboxman: new pull request created: #23923

Details

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants