Skip to content

Conversation

@kalexand-rh
Copy link
Contributor

@maxwelldb, PTAL?

@kalexand-rh kalexand-rh added this to the Future Release milestone Jul 8, 2020
@kalexand-rh kalexand-rh self-assigned this Jul 8, 2020
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@maxwelldb maxwelldb self-requested a review July 8, 2020 17:16
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I caught all that needs catching. Review my review, plz.

Copy link
Contributor Author

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will you squash?

@kalexand-rh kalexand-rh merged commit 4ab7423 into openshift:master Jul 8, 2020
@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-4.5

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #23555

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh deleted the table_end branch July 8, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants