Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Jul 6, 2020

The script consuming the YAML landed without region consumers in bd08aca (#17043), and still has no consumers for that property.

/assign @adellape

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 6, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2020
The script consuming the YAML landed without 'region' consumers in
bd08aca (Add GCP UPI install docs, 2019-10-03, openshift#17043), and still
has no consumers for that property.
@wking wking force-pushed the drop-unused-compute-region branch from a62cf7a to 5a4c56c Compare July 16, 2020 16:32
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2020
@wking
Copy link
Member Author

wking commented Jul 16, 2020

Rebased around #22332 with a62cf7a40 -> 5a4c56c.

@kalexand-rh
Copy link
Contributor

@shellyyang1989, will you PTAL?

@kalexand-rh
Copy link
Contributor

@shellyyang1989, @wking, will one of you confirm which versions this change applies to?

@wking
Copy link
Member Author

wking commented Jul 17, 2020

This fixes #17043, so back to 4.2.

@shellyyang1989
Copy link

@kalexand-rh LGTM. By the way, I logged a bz for it before. And 'region' in control plane needs to be dropped as well. https://bugzilla.redhat.com/show_bug.cgi?id=1852448

@kalexand-rh
Copy link
Contributor

Thank you @shellyyang1989 and @wking! I'm going to merge this PR and open a follow-up to address the rest of https://bugzilla.redhat.com/show_bug.cgi?id=1852448.

@kalexand-rh kalexand-rh merged commit 1751db5 into openshift:master Jul 27, 2020
@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.3

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.4

@openshift-cherrypick-robot

@kalexand-rh: #23500 failed to apply on top of branch "enterprise-4.3":

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.5

@openshift-cherrypick-robot

@kalexand-rh: #23500 failed to apply on top of branch "enterprise-4.4":

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #24213

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #24214

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants