-
Notifications
You must be signed in to change notification settings - Fork 1.9k
modules/installation-creating-gcp-worker: Drop 'region' from YAML #23500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules/installation-creating-gcp-worker: Drop 'region' from YAML #23500
Conversation
The script consuming the YAML landed without 'region' consumers in bd08aca (Add GCP UPI install docs, 2019-10-03, openshift#17043), and still has no consumers for that property.
a62cf7a to
5a4c56c
Compare
|
@shellyyang1989, will you PTAL? |
|
@shellyyang1989, @wking, will one of you confirm which versions this change applies to? |
|
This fixes #17043, so back to 4.2. |
|
@kalexand-rh LGTM. By the way, I logged a bz for it before. And 'region' in control plane needs to be dropped as well. https://bugzilla.redhat.com/show_bug.cgi?id=1852448 |
|
Thank you @shellyyang1989 and @wking! I'm going to merge this PR and open a follow-up to address the rest of https://bugzilla.redhat.com/show_bug.cgi?id=1852448. |
|
/cherrypick enterprise-4.3 |
|
/cherrypick enterprise-4.4 |
|
@kalexand-rh: #23500 failed to apply on top of branch "enterprise-4.3": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.5 |
|
@kalexand-rh: #23500 failed to apply on top of branch "enterprise-4.4": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.6 |
|
@kalexand-rh: new pull request created: #24213 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kalexand-rh: new pull request created: #24214 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The script consuming the YAML landed without
regionconsumers in bd08aca (#17043), and still has no consumers for that property./assign @adellape