Skip to content

OpenStack: Add scaling information for API and Ingress #23467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxwelldb merged 8 commits into from
Dec 15, 2020
Merged

OpenStack: Add scaling information for API and Ingress #23467

maxwelldb merged 8 commits into from
Dec 15, 2020

Conversation

@luis5tb
Copy link
Contributor

@luis5tb luis5tb commented Jul 6, 2020

Information about how to scale Ingress for environments with Kuryr, and API for environments both with and without Kuryr

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 6, 2020
@maxwelldb
Copy link
Contributor

maxwelldb commented Jul 6, 2020

Note: next steps @ https://docs.openshift.com/container-platform/4.4/installing/installing_openstack/installing-openstack-installer-kuryr.html#installation-osp-configuring-api-floating-ip_installing-openstack-installer-kuryr and similar assemblies should link to this.

@luis5tb let me know if this is incorrect—I’m still eating breakfast 😀

@luis5tb
Copy link
Contributor Author

luis5tb commented Jul 7, 2020

Note: next steps @ https://docs.openshift.com/container-platform/4.4/installing/installing_openstack/installing-openstack-installer-kuryr.html#installation-osp-configuring-api-floating-ip_installing-openstack-installer-kuryr and similar assemblies should link to this.

@luis5tb let me know if this is incorrect—I’m still eating breakfast grinning

sounds good!

@luis5tb luis5tb force-pushed the kuryr-ingress-scaling branch from c7714a5 to 7d3768d Compare July 8, 2020 07:23
@maxwelldb maxwelldb self-requested a review July 8, 2020 14:19
@maxwelldb
Copy link
Contributor

maxwelldb commented Jul 8, 2020

@luis5tb Which versions does this apply to?

celebdor
celebdor suggested changes Jul 8, 2020
View reviewed changes
@maxwelldb maxwelldb requested review from maxwelldb and removed request for maxwelldb August 10, 2020 13:51
@maxwelldb
Copy link
Contributor

maxwelldb commented Aug 10, 2020

@luis5tb To be clear, which releases does this apply to?

@luis5tb
Copy link
Contributor Author

luis5tb commented Aug 11, 2020

@luis5tb To be clear, which releases does this apply to?

4.6 and 4.5

@luis5tb luis5tb force-pushed the kuryr-ingress-scaling branch from 7d3768d to 576162a Compare August 11, 2020 09:27
@maxwelldb maxwelldb added this to the Future Release milestone Aug 11, 2020
maxwelldb
maxwelldb reviewed Aug 26, 2020
View reviewed changes
@maxwelldb
Copy link
Contributor

maxwelldb commented Aug 26, 2020

Made it through 304837b. Let me know what you think. Will keep at this this week.

maxwelldb
maxwelldb requested changes Aug 26, 2020
View reviewed changes
maxwelldb
maxwelldb reviewed Sep 18, 2020
View reviewed changes
@maxwelldb maxwelldb self-requested a review September 18, 2020 15:56
luis5tb
luis5tb commented Sep 21, 2020
View reviewed changes
@maxwelldb maxwelldb mentioned this pull request Sep 28, 2020
Merged
maxwelldb
maxwelldb previously requested changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luis5tb I've started a PR for edits here: luis5tb#3

Let me know what you think.

@luis5tb
Copy link
Contributor Author

luis5tb commented Sep 29, 2020

@luis5tb I've started a PR for edits here: luis5tb#3

Let me know what you think.

Looks pretty good! thanks!

bmcelvee
bmcelvee reviewed Dec 15, 2020
View reviewed changes
bmcelvee
bmcelvee reviewed Dec 15, 2020
View reviewed changes
bmcelvee
bmcelvee reviewed Dec 15, 2020
View reviewed changes
bmcelvee
bmcelvee reviewed Dec 15, 2020
View reviewed changes
bmcelvee
bmcelvee reviewed Dec 15, 2020
View reviewed changes
@bmcelvee
Copy link
Contributor

bmcelvee commented Dec 15, 2020

I left a few suggestions, otherwise LGTM!

@bmcelvee bmcelvee added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 15, 2020
@maxwelldb maxwelldb self-requested a review December 15, 2020 19:27
@maxwelldb maxwelldb merged commit b0700f7 into openshift:master Dec 15, 2020
@maxwelldb
Copy link
Contributor

maxwelldb commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

/cherry-pick enterprise-4.5

@maxwelldb
Copy link
Contributor

maxwelldb commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

@maxwelldb: #23467 failed to apply on top of branch "enterprise-4.5":

Applying: OpenStack: Add scaling information for API and Ingress
Applying: Edits for task mod
Applying: Edits for task mod
.git/rebase-apply/patch:57: trailing whitespace.
. From a command line, create an Octavia load balancer that uses the Amphora driver: 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/installation-osp-kuryr-ingress-scaling.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-osp-kuryr-ingress-scaling.adoc
CONFLICT (content): Merge conflict in modules/installation-osp-kuryr-ingress-scaling.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Edits for task mod
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb
Copy link
Contributor

maxwelldb commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

@maxwelldb: #23467 failed to apply on top of branch "enterprise-4.6":

Applying: OpenStack: Add scaling information for API and Ingress
Applying: Edits for task mod
Applying: Edits for task mod
.git/rebase-apply/patch:57: trailing whitespace.
. From a command line, create an Octavia load balancer that uses the Amphora driver: 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/installation-osp-kuryr-ingress-scaling.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-osp-kuryr-ingress-scaling.adoc
CONFLICT (content): Merge conflict in modules/installation-osp-kuryr-ingress-scaling.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Edits for task mod
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

@maxwelldb: #23467 failed to apply on top of branch "enterprise-4.7":

Applying: OpenStack: Add scaling information for API and Ingress
Applying: Edits for task mod
Applying: Edits for task mod
.git/rebase-apply/patch:57: trailing whitespace.
. From a command line, create an Octavia load balancer that uses the Amphora driver: 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/installation-osp-kuryr-ingress-scaling.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-osp-kuryr-ingress-scaling.adoc
CONFLICT (content): Merge conflict in modules/installation-osp-kuryr-ingress-scaling.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Edits for task mod
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb maxwelldb mentioned this pull request Dec 15, 2020
Merged
@maxwelldb
Copy link
Contributor

maxwelldb commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

@maxwelldb: #23467 failed to apply on top of branch "enterprise-4.6":

Applying: OpenStack: Add scaling information for API and Ingress
Applying: Edits for task mod
Applying: Edits for task mod
.git/rebase-apply/patch:57: trailing whitespace.
. From a command line, create an Octavia load balancer that uses the Amphora driver: 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/installation-osp-kuryr-ingress-scaling.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-osp-kuryr-ingress-scaling.adoc
CONFLICT (content): Merge conflict in modules/installation-osp-kuryr-ingress-scaling.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Edits for task mod
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maxwelldb added a commit to maxwelldb/openshift-docs that referenced this pull request Dec 15, 2020
@luis5tb @maxwelldb
OpenStack: Add scaling information for API and Ingress (openshift#23467)
c192609 
Add scaling information for API and Ingress

Co-authored-by: Max Bridges <[email protected]>
maxwelldb added a commit to maxwelldb/openshift-docs that referenced this pull request Dec 15, 2020
@luis5tb @maxwelldb
OpenStack: Add scaling information for API and Ingress (openshift#23467)
9b20218 
Add scaling information for API and Ingress

Co-authored-by: Max Bridges <[email protected]>
This was referenced Dec 15, 2020
Merged
Merged
maxwelldb added a commit that referenced this pull request Dec 15, 2020
@maxwelldb
Merge pull request #28143 from maxwelldb/enterprise-4.5
1381374 
[enterprise-4.5] OpenStack: Add scaling information for API and Ingress (#23467)
maxwelldb added a commit to maxwelldb/openshift-docs that referenced this pull request Dec 15, 2020
@luis5tb @maxwelldb
OpenStack: Add scaling information for API and Ingress (openshift#23467)
035c231 
Add scaling information for API and Ingress

Co-authored-by: Max Bridges <[email protected]>
@maxwelldb maxwelldb mentioned this pull request Dec 15, 2020
Merged
@yuvalk yuvalk mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmcelvee bmcelvee bmcelvee approved these changes

@maxwelldb maxwelldb maxwelldb approved these changes

+2 more reviewers

@celebdor celebdor celebdor requested changes

@rlobillo rlobillo rlobillo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@luis5tb luis5tb

@maxwelldb maxwelldb

@rlobillo rlobillo

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

9 participants

@luis5tb @maxwelldb @eurijon @bmcelvee @openshift-cherrypick-robot @celebdor @rlobillo @openshift-ci-robot @kalexand-rh