Skip to content

Add ShiftStack 4.5 RN items #23309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxwelldb merged 2 commits into from
Jul 6, 2020
Merged

Add ShiftStack 4.5 RN items #23309

maxwelldb merged 2 commits into from
Jul 6, 2020

Conversation

@maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Jun 25, 2020

FYI @codyhoag @jeana-redhat

Still getting feedback about what to put here.

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Jun 25, 2020

@racedo @EricArrakis We're starting to pull together 4.5 release notes. Let me know if what's up here seems anemic or suspect!

@luis5tb Which of the Kuryr items do you think should get an add here?

@maxwelldb maxwelldb self-assigned this Jun 25, 2020
@maxwelldb maxwelldb added this to the Future Release milestone Jun 25, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Jun 26, 2020

@racedo @EricArrakis We're starting to pull together 4.5 release notes. Let me know if what's up here seems anemic or suspect!

@luis5tb Which of the Kuryr items do you think should get an add here?

I would mention the support for OSP upgrades to make use of new Octavia functionality, specifically mention the removal of the hack for DNS resolution over TCP.

Other than that we have other 2 more or less internal things, not sure if work highlighting:

  • Add support for must-gather, grabbing a lot of information about things related to kuryr
  • Added a new CRD named KuryrNetworks to keep track of the OpenStack network/subnet associated to the OCP namespace

@EricArrakis
Copy link

EricArrakis commented Jun 26, 2020

We also added Anti-Affinity and Manila CSI

Is "Additional networks for clusters" the "Secondary NIC" support?

cc @iamemilio @Fedosin @pierreprinetti @mandre

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Jun 26, 2020 •
edited
Loading

Yes. "Additional networks" is the phrase used upstream, so I just used that.

Manila CSI should be covered under the Storage section.

Anti-affinity wasn't a docs required change, so I'm not too sure about what to say there. Any help is appreciated. 👍

@pierreprinetti
Copy link
Member

pierreprinetti commented Jun 29, 2020

Anti-affinity wasn't a docs required change, so I'm not too sure about what to say there. Any help is appreciated

Here's how I'd sum up the change:
The Compute nodes are now scheduled on separate physical hosts if those are available.

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Jun 29, 2020

Thoughts on e24bdc7, @luis5tb?

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Jul 1, 2020

@luis5tb How about 45c8539, now?

luis5tb
luis5tb reviewed Jul 1, 2020
View reviewed changes
@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 1, 2020
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Jul 1, 2020

@codyhoag @jeana-redhat I think this is ready for peer review.

@jeana-redhat
Copy link
Contributor

jeana-redhat commented Jul 1, 2020

LGTM but I defer to @codyhoag

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Jul 6, 2020

@codyhoag Let me know if you have any concerns about this.

codyhoag
codyhoag reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay; one general question:

These RHOSP entries are all listed under the Machine API section. Should they be moved to the installation/upgrade section?

Otherwise, LGTM!

@codyhoag codyhoag added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 6, 2020
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Jul 6, 2020

@codyhoag 😱 Don't know how that happened. Yeah, installation. Thanks for the check. 👍

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Jul 6, 2020

@codyhoag Oh, I'm seeing everything that should be under Installation there already.

There's a single Node item to do with anti-affinity node scheduling. That seemed to make sense in that section to me.

Gonna rebase presently, but could you confirm that we're seeing the same thing?

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 6, 2020
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Jul 6, 2020

Ah. Saw it once I fetched and rebased. Should be fixed in the next commit.

@maxwelldb maxwelldb requested a review from codyhoag July 6, 2020 15:17
codyhoag
codyhoag approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That section placement LGTM!

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Jul 6, 2020

@codyhoag Thanks!

@maxwelldb maxwelldb merged commit f262624 into openshift:enterprise-4.5 Jul 6, 2020
@maxwelldb maxwelldb deleted the osp-4.5-rn branch July 6, 2020 15:26
@maxwelldb maxwelldb changed the title Add draft text for ShiftStack 4.5 RN items Add ShiftStack 4.5 RN items Jul 6, 2020
@yuvalk yuvalk mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat Awaiting requested review from jeana-redhat

2 more reviewers

@luis5tb luis5tb luis5tb left review comments

@codyhoag codyhoag codyhoag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maxwelldb maxwelldb

Labels

branch/enterprise-4.5 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.5 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@maxwelldb @luis5tb @EricArrakis @pierreprinetti @jeana-redhat @codyhoag @vikram-redhat @openshift-ci-robot