Kuryr: Add information about amphora to ovn-octavia upgrades #22878

luis5tb · 2020-06-15T11:52:28Z

This PR describe the steps to performan an amphora to ovn-octavia
migration when using Kuryr. This allows to avoid the problem of
generating one VM per services when using Kuryr as CNI.

This PR describe the steps to performan an amphora to ovn-octavia migration when using Kuryr. This allows to avoid the problem of generating one VM per services when using Kuryr as CNI.

maxwelldb · 2020-06-15T15:30:32Z

@luis5tb

Is there a BZ or something for this?
How urgent of a PR is it?

luis5tb · 2020-06-15T15:35:11Z

@luis5tb

1. Is there a BZ or something for this?

https://bugzilla.redhat.com/show_bug.cgi?id=1846862

2. How urgent of a PR is it?

Not urgent at the moment, as we still need to do the backport to 4.5 (of the support itself)

maxwelldb · 2020-06-15T15:41:46Z

Thanks!

maxwelldb · 2020-06-18T19:14:00Z

Note to self: This will probably have to be broken out into its own assembly. NBD, but will require restructuring the PR.

rlobillo · 2020-06-24T16:20:51Z

/lgtm upgrade worked perfectly fine following the instructions

modules/installation-osp-kuryr-octavia-configuration.adoc

maxwelldb · 2020-06-29T16:33:48Z

Thoughts on 34e8a3d, @luis5tb?

maxwelldb

How's this, now, @luis5tb?

modules/installation-osp-kuryr-octavia-configuration.adoc

luis5tb · 2020-07-03T07:12:38Z

modules/installation-osp-kuryr-octavia-configuration.adoc

+----
+<1> Delete this line. The cluster will regenerate it with `ovn` as the value.
+
+After making this modification, wait for the `kuryr-controller` and `kuryr-cni` pods to redeploy. This process may take several minutes.


this should be "wait until the Cluster Network Operator detects the modification and redeploy the kuryr-controller and kuryr-cnis"

maxwelldb · 2020-07-03T13:27:42Z

@luis5tb Made a few more changes based on your comments. I also moved the topic into the Networking section, as it seems like this task must task place post-installation. Thoughts?

http://file.rdu.redhat.com/mbridges/Jul03/octavia-upgrade/networking/load-balancing-openstack.html

luis5tb · 2020-07-03T15:25:03Z

@luis5tb Made a few more changes based on your comments. I also moved the topic into the Networking section, as it seems like this task must task place post-installation. Thoughts?

http://file.rdu.redhat.com/mbridges/Jul03/octavia-upgrade/networking/load-balancing-openstack.html

I like the idea of having it as a different section, but not the naming of it. This is specific to Kuryr and ovn-octavia, and it is not mentioned on the title or link. It could be misleading. Perhaps in the same way as there is a section there named "Using SCTP", we can call this one "Using OVN-Octavia loadbalancer with Kuryr SDN"

maxwelldb · 2020-07-03T16:28:26Z

@luis5tb My thought is to make an OSP load balancing space now, with this topic as the sole section in it. Later, it would also contain more general OSP load balancing information (there's a topic that was pulled a few releases ago that might be fit for inclusion).

So, it would end up like:
Networking -> Load balancing with OpenStack -> Using the OVN Octavia load balancer with Kuryr SDN

Does that seem sensible?

luis5tb · 2020-07-06T15:19:50Z

@luis5tb Made a small change that I thought made sense for the title. See preview here: http://file.rdu.redhat.com/mbridges/Jul06/octavia-upgrade/networking/load-balancing-openstack.html

/lgtm

openshift-ci-robot · 2020-07-06T15:19:51Z

@luis5tb: you cannot LGTM your own PR.

Details

In response to this:

@luis5tb Made a small change that I thought made sense for the title. See preview here: http://file.rdu.redhat.com/mbridges/Jul06/octavia-upgrade/networking/load-balancing-openstack.html

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maxwelldb · 2020-07-06T15:22:31Z

Thanks!

@luis5tb Did you work with any QE folks on this who'd know it best and could ack this PR, or should I just mention a bunch of Kuryr QE team folks here? 😁

luis5tb · 2020-07-06T15:56:45Z

Thanks!

@luis5tb Did you work with any QE folks on this who'd know it best and could ack this PR, or should I just mention a bunch of Kuryr QE team folks here?

@rlobillo already tested this

maxwelldb · 2020-07-06T16:16:36Z

Cool. Just need a +1 from him here and it's ready for peer review.

rlobillo · 2020-07-07T13:53:08Z

/lgtm

maxwelldb · 2020-07-07T14:03:10Z

@openshift/team-documentation PTAL. Large change.

bobfuru

Some nitpicks based on guidelines and don't forget to squash commits. Otherwise, LGTM.

installing/installing_openstack/installing-openstack-installer-kuryr.adoc

modules/installation-osp-kuryr-octavia-upgrade.adoc

openshift-ci-robot · 2020-07-07T19:54:12Z

New changes are detected. LGTM label has been removed.

…ft#22878) This PR adds a procedure for upgrading from an amphora to ovn-octavia provider driver when using OCP + Kuryr on OSP. Co-authored-by: Max Bridges <mbridges@redhat.com>

[enterprise-4.5] Kuryr: Add information about amphora to ovn-octavia upgrades (#22878)

Kuryr: Add information about amphora to ovn-octavia upgrades

afa2c60

This PR describe the steps to performan an amphora to ovn-octavia migration when using Kuryr. This allows to avoid the problem of generating one VM per services when using Kuryr as CNI.

maxwelldb self-requested a review June 15, 2020 15:29

maxwelldb added the branch/enterprise-4.5 label Jun 15, 2020

maxwelldb added this to the Next Release milestone Jun 15, 2020

maxwelldb requested changes Jun 25, 2020

View reviewed changes

modules/installation-osp-kuryr-octavia-configuration.adoc Outdated Show resolved Hide resolved

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2020

maxwelldb self-requested a review June 26, 2020 16:40

Merge branch 'master' into octavia-upgrades

1a07f9e

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2020

Editing pass

34e8a3d

maxwelldb self-assigned this Jul 2, 2020

Changes from dev comments

a77739f

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 2, 2020

maxwelldb requested changes Jul 2, 2020

View reviewed changes

luis5tb commented Jul 3, 2020

View reviewed changes

modules/installation-osp-kuryr-octavia-configuration.adoc Outdated Show resolved Hide resolved

luis5tb commented Jul 3, 2020

View reviewed changes

maxwelldb added 2 commits July 3, 2020 07:50

Dev feedback tweak

2a5d089

Some rewording, then moving content to Networking

fef0d7c

maxwelldb assigned luis5tb Jul 3, 2020

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2020

maxwelldb approved these changes Jul 6, 2020

View reviewed changes

maxwelldb requested a review from rlobillo July 6, 2020 16:16

openshift-ci-robot assigned rlobillo Jul 7, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020

maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 7, 2020

bobfuru self-requested a review July 7, 2020 15:39

bobfuru reviewed Jul 7, 2020

View reviewed changes

bobfuru added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 7, 2020

maxwelldb self-requested a review July 7, 2020 17:50

Addressing peer review feedback

c582b35

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020

maxwelldb approved these changes Jul 7, 2020

View reviewed changes

maxwelldb removed the request for review from rlobillo July 7, 2020 20:08

maxwelldb merged commit ee1a159 into openshift:master Jul 7, 2020

maxwelldb mentioned this pull request Jul 7, 2020

[enterprise-4.5] Kuryr: Add information about amphora to ovn-octavia upgrades (#22878) #23527

Merged

maxwelldb added a commit that referenced this pull request Jul 7, 2020

Merge pull request #23527 from maxwelldb/enterprise-4.5

fb269ed

[enterprise-4.5] Kuryr: Add information about amphora to ovn-octavia upgrades (#22878)

maxwelldb mentioned this pull request Jul 13, 2020

Remove outdated Kuryr + Octavia compatibility notes #23716

Merged

yuvalk mentioned this pull request Mar 18, 2021

cnf 4.6 references #30640

Closed

Kuryr: Add information about amphora to ovn-octavia upgrades #22878

Kuryr: Add information about amphora to ovn-octavia upgrades #22878

Uh oh!

Conversation

luis5tb commented Jun 15, 2020

Uh oh!

maxwelldb commented Jun 15, 2020

Uh oh!

luis5tb commented Jun 15, 2020

Uh oh!

maxwelldb commented Jun 15, 2020

Uh oh!

maxwelldb commented Jun 18, 2020

Uh oh!

rlobillo commented Jun 24, 2020

Uh oh!

Uh oh!

maxwelldb commented Jun 29, 2020

Uh oh!

maxwelldb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

luis5tb Jul 3, 2020

Choose a reason for hiding this comment

Uh oh!

maxwelldb commented Jul 3, 2020

Uh oh!

luis5tb commented Jul 3, 2020

Uh oh!

maxwelldb commented Jul 3, 2020

Uh oh!

luis5tb commented Jul 6, 2020

Uh oh!

openshift-ci-robot commented Jul 6, 2020

Uh oh!

maxwelldb commented Jul 6, 2020

Uh oh!

luis5tb commented Jul 6, 2020

Uh oh!

maxwelldb commented Jul 6, 2020

Uh oh!

rlobillo commented Jul 7, 2020

Uh oh!

maxwelldb commented Jul 7, 2020

Uh oh!

bobfuru left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bobfuru left a comment •

edited

Loading