-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add details about GPU resources for Knative services #22791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The preview will be available shortly at: |
rhuss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! Added some question for some extra content, but not sure whether we can deliver this (at least not me ;-).
6d0cb17 to
0745543
Compare
|
Something else I've noticed - the third party docs we link out to are only for 4.1/4.2/4.3 - will this be supported for 4.4, 4.5? @markito |
|
QE approved |
bobfuru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions...after they are updated, this LGTM. I didn't add labels because it looks like you're still trying to determine those.
|
Thanks so much for the review and great comments @bobfuru - this should be ready to merge now. |
|
/cherrypick enterprise-4.5 |
|
@bobfuru: #22791 failed to apply on top of branch "enterprise-4.5": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.