Skip to content

Conversation

@0xmichalis
Copy link

No description provided.

@0xmichalis 0xmichalis changed the title Add build-chain doc [DO NOT MERGE] Add build-chain doc Mar 17, 2015
@0xmichalis 0xmichalis changed the title [DO NOT MERGE] Add build-chain doc Add build-chain doc Mar 19, 2015
@adellape
Copy link
Contributor

@Kargakis Thanks. I'll wait for the code PR to merge before merging the docs here.

BTW, the new file won't show up in the TOC until it's added to the _build_cfg.yml tree.

@0xmichalis
Copy link
Author

BTW, the new file won't show up in the TOC until it's added to the _build_cfg.yml tree.

@adellape thanks for pointing this out, I have updated the YAML file with the appropriate changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we using namespace/imagerepo syntax here when we use "-n namespace" to specify the namespace in all our other commands?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needs to indicate what happens if you do not specifiy a tag (assumes "latest" right?)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was probably carried away with the parsing of DockerImageReferences...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needs to indicate what happens if you do not specifiy a tag (assumes "latest" right?)

Yep

@0xmichalis
Copy link
Author

@bparees are you ok with this now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will use the "latest" tag since none is specified, right? should indicate that.

@bparees
Copy link
Contributor

bparees commented Mar 24, 2015

@Kargakis one minor comment and then lgtm.

@0xmichalis
Copy link
Author

@adellape this can now get merged

@adellape
Copy link
Contributor

@Kargakis Thanks, merging.

@tpoitras FYI per https://trello.com/c/QeyUIKd8.

adellape added a commit that referenced this pull request Mar 25, 2015
@adellape adellape merged commit 4cee2f4 into openshift:master Mar 25, 2015
@0xmichalis 0xmichalis deleted the build-chain branch March 25, 2015 21:49
sbeskin-redhat pushed a commit to sbeskin-redhat/openshift-docs that referenced this pull request Oct 24, 2022
WINDUP-2180: Include the disableTattletale report option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants