-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add build-chain doc #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build-chain doc #225
Conversation
|
@Kargakis Thanks. I'll wait for the code PR to merge before merging the docs here. BTW, the new file won't show up in the TOC until it's added to the |
@adellape thanks for pointing this out, I have updated the YAML file with the appropriate changes. |
using_openshift/output_deps.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we using namespace/imagerepo syntax here when we use "-n namespace" to specify the namespace in all our other commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also needs to indicate what happens if you do not specifiy a tag (assumes "latest" right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was probably carried away with the parsing of DockerImageReferences...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also needs to indicate what happens if you do not specifiy a tag (assumes "latest" right?)
Yep
|
@bparees are you ok with this now? |
using_openshift/output_deps.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will use the "latest" tag since none is specified, right? should indicate that.
|
@Kargakis one minor comment and then lgtm. |
|
@adellape this can now get merged |
|
@Kargakis Thanks, merging. @tpoitras FYI per https://trello.com/c/QeyUIKd8. |
WINDUP-2180: Include the disableTattletale report option.
No description provided.