-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Jaeger configuration and deployment options (#20643 restored) #22296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The preview will be available shortly at: |
|
@JStickler On re-reading the PR, do you think we need a more explicit statement that Jaeger has been tested (and is supported) with AMQ streams, rather than other kafka products? |
|
@objectiser, rather than hold up this PR, why don't we create an issue so that we can work out what to say (and where to put the content, since we don't have a "supported configurations" topic yet, and should probably add one). |
|
@JStickler Created https://issues.redhat.com/browse/TRACING-1212 to track that. Added to sprint #41 but feel free to schedule in whichever sprint you think appropriate. |
4948b44 to
b6a3bb1
Compare
neal-timpe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are a couple of items that need review before merging.
6981a34 to
b2329c9
Compare
|
/cherry-pick enterprise-4.3 |
|
@neal-timpe: #22296 failed to apply on top of branch "enterprise-4.3": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.4 |
|
@neal-timpe: new pull request created: #22629 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.5 |
|
@neal-timpe: new pull request created: #22630 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Applying #22296 to the 4.3 branch.
I had two PRs open in different tabs and merged #20643 by accident while I was trying to troubleshoot build errors. This PR contains all the changes from that PR.