-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Secondary NIC support for OSP IPI - OSDOCS-1033 #22174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secondary NIC support for OSP IPI - OSDOCS-1033 #22174
Conversation
|
The preview will be available shortly at: |
|
At the moment, this PR just includes relevant params. Unsure about additional work required at this point. |
3d2f465 to
fb2e976
Compare
|
@wjiangjay Would you be able to review this PR? |
|
QE ack in Jira w/CSS comment to address (c115197) |
|
@kalexand-rh Would you be able to look at this given that your tables are magnificent? 🥇 |
kalexand-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One pick, one gripe. I hope you can file a bug for that wrapping problem.
|
@vikram-redhat Would you be able to take a look at this? Kathryn and I do not understand how we can use identical column options for the "Required parameters" and "Optional {rh-openstack} parameters" tables with different results. :( |
|
@adellape No rush at all, but Vikram mentioned that you might have an idea about this problem. Look quite different. :( All have the same col options: Their content is similar, too, but text wrapping is only borked in the final example. Any thoughts about what's going on? |
|
@maxwelldb It looks like since the verbatim marked-up names in the "Parameter" column are being considered single words that can't wrap, that first column becomes as wide at the longest entry, squishing the other columns. In that final example's case, it's |
|
/cherry-pick enterprise-4.5 |
|
@maxwelldb: #22174 failed to apply on top of branch "enterprise-4.5": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[enterprise-4.5] Secondary NIC support for OSP IPI - OSDOCS-1033 (#22174)



Context: https://issues.redhat.com/browse/OSDOCS-1033