Skip to content

Conversation

@maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb added this to the Future Release milestone May 15, 2020
@maxwelldb maxwelldb self-assigned this May 15, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@maxwelldb
Copy link
Contributor Author

At the moment, this PR just includes relevant params. Unsure about additional work required at this point.

@maxwelldb maxwelldb requested a review from Fedosin May 15, 2020 17:56
@maxwelldb maxwelldb force-pushed the osp-secondary-nic-osdocs1033 branch from 3d2f465 to fb2e976 Compare May 20, 2020 13:49
@maxwelldb maxwelldb marked this pull request as ready for review June 22, 2020 17:34
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2020
@maxwelldb
Copy link
Contributor Author

@wjiangjay Would you be able to review this PR?

@maxwelldb
Copy link
Contributor Author

QE ack in Jira w/CSS comment to address (c115197)

@maxwelldb
Copy link
Contributor Author

@kalexand-rh Would you be able to look at this given that your tables are magnificent? 🥇

@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 23, 2020
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One pick, one gripe. I hope you can file a bug for that wrapping problem.

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 24, 2020
@maxwelldb
Copy link
Contributor Author

@vikram-redhat Would you be able to take a look at this? Kathryn and I do not understand how we can use identical column options for the "Required parameters" and "Optional {rh-openstack} parameters" tables with different results. :(

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Jun 30, 2020

@adellape No rush at all, but Vikram mentioned that you might have an idea about this problem.

This row:
image

This row:
image

And this row:
image

Look quite different. :(

All have the same col options:
cols=".^2,.^3,.^5a"

Their content is similar, too, but text wrapping is only borked in the final example.

Any thoughts about what's going on?

Cursed preview tables: https://osp-secondary-nic-osdocs1033--ocpdocs.netlify.app/openshift-enterprise/latest/installing/installing_openstack/installing-openstack-user-kuryr.html#installation-configuration-parameters_installing-openstack-user-kuryr

@adellape
Copy link
Contributor

adellape commented Jun 30, 2020

@maxwelldb It looks like since the verbatim marked-up names in the "Parameter" column are being considered single words that can't wrap, that first column becomes as wide at the longest entry, squishing the other columns. In that final example's case, it's controlPlane.platform.openstack.additionalSecurityGroupIDs. In your first example, however, there is a <platform>, and it looks like for some reason it does wrap when it hits a <. When I threw some <> around the long ones in the final example's table, it wrapped them and narrowed the columns.

@maxwelldb
Copy link
Contributor Author

@adellape 🙇‍♂️ https://giphy.com/gifs/cat-dead-NjevnbNiUmeLm

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 2, 2020
@maxwelldb maxwelldb merged commit 55c089b into openshift:master Jul 2, 2020
@maxwelldb
Copy link
Contributor Author

/cherry-pick enterprise-4.5

@openshift-cherrypick-robot

@maxwelldb: #22174 failed to apply on top of branch "enterprise-4.5":

Applying: Move optional params into separate table
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
Applying: Cleaning up linebreaks
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
Patch failed at 0003 Cleaning up linebreaks

Details

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maxwelldb added a commit to maxwelldb/openshift-docs that referenced this pull request Jul 2, 2020
maxwelldb added a commit that referenced this pull request Jul 2, 2020
[enterprise-4.5] Secondary NIC support for OSP IPI - OSDOCS-1033 (#22174)
@yuvalk yuvalk mentioned this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants