Skip to content

Conversation

@ahardin-rh
Copy link
Contributor

Follow-up to #2020

@ahardin-rh
Copy link
Contributor Author

@tnguyen-rh @bfallonf @tpoitras PTAL. Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • s/we check/{product-title} checks/
  • Probably the last two sentences can be coalesced, something like: "... checks to ensure ... in namespace, and returns a 403 if that check fails." Tangentially, i'm not sure if naked "a 403" is ok. Maybe it's better to stick with the two sentences and say "If the check fails, the request fails with a 403 (Forbidden) error code." (presuming this is the 403 in question).

@tnguyen-rh
Copy link

@ahardin-rh Some minor touch-ups, otherwise LGTM. 👍

@ahardin-rh
Copy link
Contributor Author

@tnguyen-rh you rock! Thank you for your thoughtful comments. 🎸 🤘

@ahardin-rh ahardin-rh merged commit b6f0517 into openshift:master May 25, 2016
@ahardin-rh
Copy link
Contributor Author

ahardin-rh commented May 25, 2016

[rev_history]
|link:../architecture/additional_concepts/authentication.html[Additional Concepts -> Authentication]
|Added the link:../architecture/additional_concepts/authentication.html#authentication-impersonation[Impersonation] section.
%

@tnguyen-rh
Copy link

@ahardin-rh FYI, i modified the revhist note to add "Additional Concepts -> ".

@ahardin-rh
Copy link
Contributor Author

@tnguyen-rh Perfect! Thank you!

@tpoitras tpoitras modified the milestones: Staging, Next Release May 29, 2016
@vikram-redhat vikram-redhat modified the milestones: Staging, Published - 30 May, 2016 May 30, 2016
@adellape adellape modified the milestones: Published - 05/30/16, Staging, Next Release Jun 7, 2016
@adellape
Copy link
Contributor

adellape commented Jun 7, 2016

See #2020 (comment)

@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Oct 7, 2016
@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Nov 7, 2016
@ahardin-rh ahardin-rh deleted the 2020-followup branch November 30, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants