-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Follow-up to Explain Impersonation (PR#2020) #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tnguyen-rh @bfallonf @tpoitras PTAL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- s/we check/{product-title} checks/
- Probably the last two sentences can be coalesced, something like: "... checks to ensure ... in namespace, and returns a 403 if that check fails." Tangentially, i'm not sure if naked "a 403" is ok. Maybe it's better to stick with the two sentences and say "If the check fails, the request fails with a 403 (Forbidden) error code." (presuming this is the 403 in question).
|
@ahardin-rh Some minor touch-ups, otherwise LGTM. 👍 |
|
@tnguyen-rh you rock! Thank you for your thoughtful comments. 🎸 🤘 |
|
[rev_history] |
|
@ahardin-rh FYI, i modified the revhist note to add "Additional Concepts -> ". |
|
@tnguyen-rh Perfect! Thank you! |
|
See #2020 (comment) |
Follow-up to #2020