Skip to content

Add Marketplace doc to 4.4 #21179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxwelldb merged 12 commits into from
May 6, 2020
Merged

Add Marketplace doc to 4.4 #21179

maxwelldb merged 12 commits into from
May 6, 2020

Conversation

@robszumski
Copy link
Contributor

@robszumski robszumski commented Apr 15, 2020

Add s a simple doc about Red Hat Marketplace that is mostly links out to external content at marketplace.redhat.com. This location is currently behind a whitelist but I can show you that content if required.

I am happy to make changes or have someone take over this PR if that is easier.

cc: @maxwelldb

@maxwelldb maxwelldb requested review from aheslin and maxwelldb April 15, 2020 16:13
@maxwelldb maxwelldb added this to the Future Release milestone Apr 22, 2020
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Apr 25, 2020

@sferich888 can you confirm that this content is ok, especially the links?

@maxwelldb what is the status with this? Does this need to be in for 4.4 GA?

@sferich888
Copy link
Contributor

sferich888 commented Apr 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2020
@maxwelldb
Copy link
Contributor

maxwelldb commented Apr 27, 2020

@vikram-redhat I'm modularizing and editing as time allows for versions 4.4 and beyond. It is not promised for 4.4 GA, no.

@maxwelldb maxwelldb marked this pull request as draft April 27, 2020 03:24
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 27, 2020

New changes are detected. LGTM label has been removed.

@maxwelldb
Copy link
Contributor

maxwelldb commented Apr 27, 2020

@robszumski Restructured this for FCC and did a little bit of editing. Thoughts?

robszumski
robszumski commented Apr 27, 2020
View reviewed changes
robszumski
robszumski commented Apr 27, 2020
View reviewed changes
Copy link
Contributor Author

@robszumski robszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added one note about your todo

@maxwelldb
Copy link
Contributor

maxwelldb commented May 1, 2020 •
edited
Loading

@robszumski Last thing: Is it important to call out a "Procurement department" specifically?

See cb55582 and a440620

@robszumski
Copy link
Contributor Author

robszumski commented May 1, 2020

@maxwelldb This was one of the use-cases, but it doesn't have to be called out that specifically.

@maxwelldb
Copy link
Contributor

maxwelldb commented May 1, 2020

@robszumski Any concerns with this content as it is, now? If not, could you squash it to a single commit, force push, and then I'll get it into peer review?

We're holding off on any merges to master or release branches until 4.4 GA, so no rush.

@robszumski
Copy link
Contributor Author

robszumski commented May 4, 2020

LGTM, squashed

@maxwelldb maxwelldb marked this pull request as ready for review May 4, 2020 13:50
@maxwelldb maxwelldb added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.5 labels May 4, 2020
@maxwelldb
Copy link
Contributor

maxwelldb commented May 4, 2020

@openshift/team-documentation PTAL at this. Ali and QE are both fine with it.

@bergerhoffer bergerhoffer self-requested a review May 4, 2020 16:00
bergerhoffer
bergerhoffer reviewed May 4, 2020
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions.

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 4, 2020
@maxwelldb
Copy link
Contributor

maxwelldb commented May 6, 2020

@robszumski How does this after incorporating fe16a76 look to you?

@robszumski
Copy link
Contributor Author

robszumski commented May 6, 2020

@maxwelldb LGTM

@maxwelldb maxwelldb merged commit 218b1e7 into openshift:master May 6, 2020
@maxwelldb
Copy link
Contributor

maxwelldb commented May 6, 2020

Trying out squash + merge GUI. Don't panic, onlookers. :)

maxwelldb added a commit to maxwelldb/openshift-docs that referenced this pull request May 6, 2020
@robszumski @maxwelldb
Add Marketplace doc to 4.4 (openshift#21179)
8bdb7d3 
* Add simple Marketplace doc

* Modularize doc

* Peer review comments + resolutions

Co-authored-by: Max Bridges <[email protected]>
maxwelldb added a commit that referenced this pull request May 6, 2020
@maxwelldb
Merge pull request #21880 from maxwelldb/enterprise-4.4
fe0191a 
[enterprise-4.4] Add Marketplace doc to 4.4 (#21179)
adellape pushed a commit to adellape/openshift-docs that referenced this pull request Sep 30, 2020
@robszumski @maxwelldb @adellape
Add Marketplace doc to 4.4 (openshift#21179)
fbd8839 
* Add simple Marketplace doc

* Modularize doc

* Peer review comments + resolutions

Co-authored-by: Max Bridges <[email protected]>
@adellape adellape mentioned this pull request Sep 30, 2020
Merged
adellape added a commit that referenced this pull request Sep 30, 2020
@adellape
Merge pull request #25957 from adellape/add_rh_mktplace_45
bba5c88 
[enterprise-4.5] Add Marketplace doc to 4.4 (#21179)
adellape pushed a commit to adellape/openshift-docs that referenced this pull request Sep 30, 2020
@robszumski @maxwelldb @adellape
Add Marketplace doc to 4.4 (openshift#21179)
eefda34 
* Add simple Marketplace doc

* Modularize doc

* Peer review comments + resolutions

Co-authored-by: Max Bridges <[email protected]>
@adellape adellape mentioned this pull request Sep 30, 2020
Merged
adellape added a commit that referenced this pull request Sep 30, 2020
@adellape
Merge pull request #25984 from adellape/add_rh_mktplace_46
a91df72 
[enterprise-4.6] Add Marketplace doc to 4.4 (#21179)
@yuvalk yuvalk mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@maxwelldb maxwelldb maxwelldb approved these changes

@aheslin aheslin Awaiting requested review from aheslin

Assignees

@robszumski robszumski

@sferich888 sferich888

@maxwelldb maxwelldb

Labels

branch/enterprise-4.4 branch/enterprise-4.5 peer-review-done Signifies that the peer review team has reviewed this PR

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@robszumski @vikram-redhat @sferich888 @maxwelldb @openshift-ci-robot @bergerhoffer