-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Splitting out Jaeger release notes for reuse. #21167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The preview will be available shortly at: |
kevinearls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small item, when I look at https://boj_6--ocpdocs.netlify.com/openshift-enterprise/latest/jaeger/rhbjaeger-release-notes.html#jaeger-rn-new-features_jaeger-release-notes under "Getting Support" it says: The unique cluster ID. Navigate to (?) Help → Open Support Case to have the cluster ID autofilled when you submit the case.
However, on a 4.3 or 4.3 console instead of "(?) Help → Open Support Case " i just see "(?) → Open Support Case "
(?) Help → Open Support Case
001333d to
f16abc8
Compare
|
@neal-timpe, would love a quick peer review of this. I was looking at both the Jaeger release notes and the Service Mesh release notes, and I think they both look OK. I was trying to make sure headings and intro sentences matched, that sort of thing. Let me know if I missed anything. |
|
|
||
| include::modules/ossm-rn-known-issues.adoc[leveloffset=+1] | ||
|
|
||
| include::modules/jaeger-rn-known-issues.adoc[leveloffset=+2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you add a Jaeger item to the topic.yml? Should this go there instead of in the sm release notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm single sourcing, publishing the same info in two sets of release notes.
neal-timpe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, just wanted to check about the modules. Otherwise LGTM.
|
@kevinearls , I did some investigation around the Help text, and it looks like the link has changed every release. I'm going to bring it up with the OCP docs team. But other than that, is there any reason why we can't merge this PR? |
kevinearls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kevinearls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/cherry-pick enterprise-4.3 |
|
@neal-timpe: new pull request created: #21581 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.4 |
|
@neal-timpe: #21167 failed to apply on top of branch "enterprise-4.4": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR pulls out the Jaeger release notes into separate topics for reuse in both Service Mesh and OpenShift Jaeger release notes.
This PR also publishes the Jaeger release notes.