Skip to content

Conversation

@JStickler
Copy link
Contributor

This PR pulls out the Jaeger release notes into separate topics for reuse in both Service Mesh and OpenShift Jaeger release notes.
This PR also publishes the Jaeger release notes.

@openshift-docs-preview-bot

The preview will be available shortly at:

Copy link

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small item, when I look at https://boj_6--ocpdocs.netlify.com/openshift-enterprise/latest/jaeger/rhbjaeger-release-notes.html#jaeger-rn-new-features_jaeger-release-notes under "Getting Support" it says: The unique cluster ID. Navigate to (?) Help → Open Support Case to have the cluster ID autofilled when you submit the case.

However, on a 4.3 or 4.3 console instead of "(?) Help → Open Support Case " i just see "(?) → Open Support Case "

(?) Help → Open Support Case

@JStickler JStickler force-pushed the BOJ_6 branch 2 times, most recently from 001333d to f16abc8 Compare April 21, 2020 20:21
@JStickler
Copy link
Contributor Author

@neal-timpe, would love a quick peer review of this. I was looking at both the Jaeger release notes and the Service Mesh release notes, and I think they both look OK. I was trying to make sure headings and intro sentences matched, that sort of thing. Let me know if I missed anything.


include::modules/ossm-rn-known-issues.adoc[leveloffset=+1]

include::modules/jaeger-rn-known-issues.adoc[leveloffset=+2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add a Jaeger item to the topic.yml? Should this go there instead of in the sm release notes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm single sourcing, publishing the same info in two sets of release notes.

Copy link
Contributor

@neal-timpe neal-timpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just wanted to check about the modules. Otherwise LGTM.

@JStickler
Copy link
Contributor Author

@kevinearls , I did some investigation around the Help text, and it looks like the link has changed every release.
◦ OpenShift 4.5 - (?) → Report Bug to Red Hat
◦ OpenShift 4.4 - (?) → Report Bug
◦ OpenShift 4.3 - (?) → Open Support Case
◦ OpenShift 4.2 - NO LINK

I'm going to bring it up with the OCP docs team. But other than that, is there any reason why we can't merge this PR?

Copy link

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neal-timpe neal-timpe merged commit 4447b4a into openshift:master Apr 27, 2020
@neal-timpe
Copy link
Contributor

/cherry-pick enterprise-4.3

@openshift-cherrypick-robot

@neal-timpe: new pull request created: #21581

Details

In response to this:

/cherry-pick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe
Copy link
Contributor

/cherry-pick enterprise-4.4

@openshift-cherrypick-robot

@neal-timpe: #21167 failed to apply on top of branch "enterprise-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	_topic_map.yml
M	modules/ossm-rn-known-issues.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ossm-rn-known-issues.adoc
CONFLICT (content): Merge conflict in modules/ossm-rn-known-issues.adoc
Auto-merging _topic_map.yml
Patch failed at 0001 Splitting out Jaeger release notes for reuse.

Details

In response to this:

/cherry-pick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JStickler added a commit to JStickler/openshift-docs that referenced this pull request Apr 27, 2020
neal-timpe added a commit that referenced this pull request Apr 27, 2020
@JStickler JStickler deleted the BOJ_6 branch November 11, 2020 15:54
@yuvalk yuvalk mentioned this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants