OSDOCS-876: Adding docs for bound service account tokens #21118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergerhoffer
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
The preview will be available shortly at: |
bergerhoffer
commented
Apr 13, 2020
bergerhoffer
force-pushed
the
OSDOCS-876-audience
branch
from
3b2c4c1 to
09e8d68
Compare
marun
reviewed
Apr 14, 2020
marun
left a comment
marun
left a comment
There was a problem hiding this comment.
LGTM save a few suggested changes inline! Most comments are just responding to questions in the text.
bergerhoffer
force-pushed
the
OSDOCS-876-audience
branch
from
09e8d68 to
25cdf34
Compare
bergerhoffer
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
bergerhoffer
added
the
peer-review-needed
Contributor
Author
|
@openshift/team-documentation For peer review please. |
bergerhoffer
force-pushed
the
OSDOCS-876-audience
branch
from
25cdf34 to
59c4f07
Compare
bmcelvee
reviewed
Apr 15, 2020
bmcelvee
reviewed
Apr 15, 2020
bmcelvee
added
peer-review-done
Contributor
|
Just a couple of suggestions. Otherwise LGTM! |
bergerhoffer
force-pushed
the
OSDOCS-876-audience
branch
from
59c4f07 to
4657efb
Compare
Contributor
Author
|
@xingxingxia Can you review this when you get a chance? Thanks! |
|
LGTM |
Contributor
|
LGTM. CC @wangke19 (just for knowing this doc :), no review required). Thanks. |
Contributor
Author
|
/cherrypick enterprise-4.4 |
|
@bergerhoffer: new pull request created: #21224 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OSDOCS-876
Preview: https://osdocs-876-audience--ocpdocs.netlify.com/openshift-enterprise/latest/authentication/bound-service-account-tokens.html