Skip to content

Conversation

@aburdenthehand
Copy link
Contributor

Went through the 2.2 known issues and removed all the ones that have been resolved. It looks as though there are still eight bugs that are still relevant for 2.3

@openshift-docs-preview-bot

The preview will be available shortly at:

Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue with the existing file that I think should be fixed in this PR, but otherwise LGTM.

While it's on my mind, we need to increment {CNVVersion} to 2.3 in the attributes file; want to do that in this PR too?

@@ -15,49 +15,19 @@ include::modules/technology-preview.adoc[leveloffset=+2]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 13: :FeatureName: {CNVProductName} needs to be changed to :FeatureName: {CNVProductNameStart}

@aburdenthehand aburdenthehand force-pushed the cnv-release-notes-2_3 branch from b293f2b to 331d754 Compare April 2, 2020 10:57
@aburdenthehand
Copy link
Contributor Author

@ousleyp Thanks for the eyes, Pan. I updated as suggested.
I might hold off merging this so I can merge #20823 first.

…been resolved. It looks as though there are still eight bugs that are still relevant for 2.3. Also openshift#20823 likely to conflict with this due to version update
@aburdenthehand aburdenthehand force-pushed the cnv-release-notes-2_3 branch from 331d754 to a0bd33b Compare April 6, 2020 13:04
@aburdenthehand aburdenthehand merged commit 11ad62b into openshift:master Apr 6, 2020
@aburdenthehand
Copy link
Contributor Author

/cherrypick enterprise-4.4

@openshift-cherrypick-robot

@aburdenthehand: #20824 failed to apply on top of branch "enterprise-4.4":

.git/rebase-apply/patch:116: trailing whitespace.
// Temporary comment: BZ1819700 PR (#20823) likely to conflict here because of updated version change. 
warning: 1 line adds whitespace errors.
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	cnv/cnv_release_notes/cnv-release-notes.adoc
Falling back to patching base and 3-way merge...
Auto-merging cnv/cnv_release_notes/cnv-release-notes.adoc
CONFLICT (content): Merge conflict in cnv/cnv_release_notes/cnv-release-notes.adoc
Patch failed at 0001 Went through the 2.2 known issues and removed all the ones that have been resolved. It looks as though there are still eight bugs that are still relevant for 2.3. Also #20823 likely to conflict with this due to version update

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aburdenthehand
Copy link
Contributor Author

Manual cherrypick to enterprise-4.4 #20920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants