Skip to content

Add self-signed certificate steps to ShiftStack params module - OSASINFRA1122 #20355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxwelldb merged 1 commit into from
Apr 16, 2020
Merged

Add self-signed certificate steps to ShiftStack params module - OSASINFRA1122 #20355

maxwelldb merged 1 commit into from
Apr 16, 2020

Conversation

@maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Mar 9, 2020 •
edited by kalexand-rh
Loading

Addresses https://issues.redhat.com/browse/OSDOCS-922

Awaiting:

  • Dev feedback
  • QE
  • Peer review

@maxwelldb maxwelldb added this to the Future Release milestone Mar 9, 2020
@maxwelldb maxwelldb self-assigned this Mar 9, 2020
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 9, 2020
@maxwelldb maxwelldb changed the title Add SSC steps to params task - OSASINFRA1122 Add self-signed certificate steps to ShiftStack params module - OSASINFRA1122 Mar 9, 2020
@iamemilio
Copy link

iamemilio commented Mar 9, 2020

lgtm

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Mar 9, 2020

@iamemilio Thanks!

pierreprinetti
pierreprinetti reviewed Mar 10, 2020
View reviewed changes
@mandre
Copy link
Member

mandre commented Mar 27, 2020

Beside the relative path issue that @pierreprinetti spotted, this new doc looks good. Thanks @maxwelldb.

@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Mar 27, 2020

The preview will be available shortly at:

@mandre
Copy link
Member

mandre commented Mar 27, 2020

Looks great! 🚀

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Mar 27, 2020

Thanks! Squashed down to 1 commit. Awaiting QE.

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Mar 30, 2020

QE moved Jira ticket to Verified.

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Mar 31, 2020

Holding off on peer review based on https://issues.redhat.com/browse/OSASINFRA-1122?focusedCommentId=14015179&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14015179

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 13, 2020 •
edited
Loading

@morenod Any objections to removing the note here? 7e867db

e: Change is QEed in #20091. No need to verify this unless you're curious. NM. Sorry.

@maxwelldb maxwelldb requested review from morenod and removed request for morenod April 13, 2020 15:48
@morenod
Copy link

morenod commented Apr 14, 2020

lgtm

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 14, 2020

@morenod Thanks!

@maxwelldb maxwelldb requested a review from morenod April 15, 2020 16:26
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 15, 2020

@morenod One last addition: are you able to +1 the note in 8d4e0a6?

@morenod
Copy link

morenod commented Apr 16, 2020

@morenod One last addition: are you able to +1 the note in 8d4e0a6?

Perfect, rotation now works fine

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 16, 2020

Thanks!

@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 16, 2020
kalexand-rh
kalexand-rh reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of picks, then it LGTM.

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 16, 2020
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 16, 2020

@kalexand-rh Done. Thanks!

@maxwelldb
Add SSC steps to params task - OSASINFRA1122
bc18d88 
Making CA cert path absolute
@maxwelldb maxwelldb merged commit 2c2851e into openshift:master Apr 16, 2020
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 16, 2020

/cherry-pick enterprise-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 16, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 16, 2020

@maxwelldb: new pull request created: #21215

Details

In response to this:

/cherry-pick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

+3 more reviewers

@pierreprinetti pierreprinetti pierreprinetti left review comments

@iamemilio iamemilio iamemilio left review comments

@morenod morenod morenod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maxwelldb maxwelldb

Labels

branch/enterprise-4.4 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.4 GA

Development

Successfully merging this pull request may close these issues.

10 participants

@maxwelldb @iamemilio @mandre @openshift-docs-preview-bot @morenod @openshift-cherrypick-robot @pierreprinetti @kalexand-rh @vikram-redhat @openshift-ci-robot