Skip to content

Conversation

@kalexand-rh
Copy link
Contributor

@kalexand-rh kalexand-rh added this to the Future Release milestone Nov 15, 2019
@kalexand-rh kalexand-rh self-assigned this Nov 15, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2019
@openshift-docs-preview-bot

The preview will be available shortly at:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the resource group that the installer creates and provisions everything in is generated automatically, it isn't specified anywhere. The resource group that is specified is the existing one that contains existing resources.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subnets provided to the install config for Azure are both private subnets. Public IP addresses are allocated for the load balancers that sit in front of the control plane and worker nodes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something else to be aware of, is the NSG's that are created for the subnets need to have rules to allow communication with the control plane, http, https, etc. See openshift/installer#2521 (comment) for the rules I used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding a table that contains the ports that we discussed.

@kalexand-rh
Copy link
Contributor Author

@jhixson74, I've made changes that I think address your VPC-related comments. Please let me know if you have any other comments, requests, or corrections.

@etienne, will you PTAL?

@e-tienne
Copy link

LGTM

@kalexand-rh
Copy link
Contributor Author

@mgahagan73, Etienne said that you should probably take a look, too. Will you please let me know if you see any issues?

@kalexand-rh
Copy link
Contributor Author

@mgahagan73, will you PTAL?

@kalexand-rh kalexand-rh force-pushed the osdocs773 branch 2 times, most recently from 9dbb12d to 8f89cae Compare December 6, 2019 15:45
@mgahagan73
Copy link

LGTM

@kalexand-rh
Copy link
Contributor Author

@openshift/team-documentation, PTAL?

@kalexand-rh kalexand-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 11, 2019
@bergerhoffer bergerhoffer self-requested a review December 16, 2019 16:08
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things - some the same comments as the AWS PR. I tried to point things out that I saw in both, but I'd double check to make sure that I didn't miss any here that I pointed out in the AWS PR.

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 16, 2019
@kalexand-rh kalexand-rh merged commit 14a87cf into openshift:master Dec 17, 2019
@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-4.3

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #18710

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.3 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants