-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-773 Azure BYO VNet #18133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-773 Azure BYO VNet #18133
Conversation
|
The preview will be available shortly at: |
c3c96cf to
64f8730
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the resource group that the installer creates and provisions everything in is generated automatically, it isn't specified anywhere. The resource group that is specified is the existing one that contains existing resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subnets provided to the install config for Azure are both private subnets. Public IP addresses are allocated for the load balancers that sit in front of the control plane and worker nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something else to be aware of, is the NSG's that are created for the subnets need to have rules to allow communication with the control plane, http, https, etc. See openshift/installer#2521 (comment) for the rules I used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding a table that contains the ports that we discussed.
|
@jhixson74, I've made changes that I think address your VPC-related comments. Please let me know if you have any other comments, requests, or corrections. @etienne, will you PTAL? |
|
LGTM |
|
@mgahagan73, Etienne said that you should probably take a look, too. Will you please let me know if you see any issues? |
|
@mgahagan73, will you PTAL? |
9dbb12d to
8f89cae
Compare
|
LGTM |
|
@openshift/team-documentation, PTAL? |
bergerhoffer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things - some the same comments as the AWS PR. I tried to point things out that I saw in both, but I'd double check to make sure that I didn't miss any here that I pointed out in the AWS PR.
8f89cae to
3c6659e
Compare
|
/cherrypick enterprise-4.3 |
|
@kalexand-rh: new pull request created: #18710 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://jira.coreos.com/browse/OSDOCS-773
@jhixson74, will you PTAL?