Skip to content

Conversation

@ahardin-rh ahardin-rh added this to the Future Release milestone Nov 6, 2019
@ahardin-rh ahardin-rh self-assigned this Nov 6, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2019
@ahardin-rh
Copy link
Contributor Author

@spadgett PTAL. Also, is ConsoleProjectLink still targeting 4.3? I didn't see it in my latest cluster. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this button. We might suggest using Home -> Search for this since the Custom Resource Definitions list will be hidden from normal users.

Home -> Search -> ConsoleYAMLSample -> Create Console YAML Sample

Do we recommend creating the other extension resources the same way? We should be consistent.

It's probably worth calling out that typically only admins can create these resources (for YAML sample and other extension custom resources)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an optional snippet property that lets you define a fragment instead of the entire doc. See openshift/api#509

@openshift-docs-preview-bot

The preview will be available shortly at:

@ahardin-rh ahardin-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 11, 2019
Copy link
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Ashley!

@sheriff-rh sheriff-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 11, 2019
@ahardin-rh
Copy link
Contributor Author

@yapei Can you please provide QE review?

@yanpzhan
Copy link

@ahardin-rh The pr LG from QE side, thanks!

@ahardin-rh ahardin-rh merged commit 0c6e3a6 into openshift:master Nov 12, 2019
@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-4.3

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #18059

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.3 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants