-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Adding YAML examples to Kubernetes resources procedure #17929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@spadgett PTAL. Also, is ConsoleProjectLink still targeting 4.3? I didn't see it in my latest cluster. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this button. We might suggest using Home -> Search for this since the Custom Resource Definitions list will be hidden from normal users.
Home -> Search -> ConsoleYAMLSample -> Create Console YAML Sample
Do we recommend creating the other extension resources the same way? We should be consistent.
It's probably worth calling out that typically only admins can create these resources (for YAML sample and other extension custom resources)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an optional snippet property that lets you define a fragment instead of the entire doc. See openshift/api#509
|
The preview will be available shortly at: |
5da4136 to
a2c7010
Compare
a2c7010 to
f123e2e
Compare
Co-Authored-By: Sam Padgett <[email protected]>
sheriff-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Ashley!
|
@yapei Can you please provide QE review? |
|
@ahardin-rh The pr LG from QE side, thanks! |
|
/cherrypick enterprise-4.3 |
|
@ahardin-rh: new pull request created: #18059 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Preview Build: http://file.rdu.redhat.com/~ahardin/11062019/console-yaml-sample/web-console/customizing-the-web-console.html#adding-yaml-examples-to-kube-resources_customizing-web-console
https://jira.coreos.com/browse/PROD-1817