Indefinite article change for RHOSP abbreviation #17323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
Contributor
Author
|
@bergerhoffer Do you want this one? |
Contributor
bergerhoffer
left a comment
bergerhoffer
left a comment
There was a problem hiding this comment.
Just a few minor things, otherwise looks good!
bergerhoffer
added
peer-review-done
Contributor
Author
|
@bergerhoffer Think I hit all of your comments. Let me know and I'll autosquash this. |
Contributor
|
@maxwelldb Yep looks good to me now if you want to go ahead and squash! And then just let me know if you're ready for me to merge after that. |
Adding OSP to common-atributes Replacing OpenStack and RHOSP terms w/attributes
maxwelldb
force-pushed
the
openstack-branding-rename
branch
from
cbac9f4 to
7bd4f87
Compare
Contributor
Author
|
@bergerhoffer Done. Thanks! Merge away. |
Contributor
Author
|
Realized I reflexively edited in "Merge away" into that last comment. Just so that's in your inbox, too, hello @bergerhoffer |
Contributor
|
Appreciate the clarification, merging/picking! |
Contributor
|
/cherrypick enterprise-4.2 |
|
@bergerhoffer: #17323 failed to apply on top of branch "enterprise-4.2": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
/cherrypick enterprise-4.2 |
|
@bergerhoffer: new pull request created: #17337 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally:
Context: #17304
For 4.2.