modules/installation-bootstrap-gather: --master for each machine

[wking]

This is what we do in CI since openshift/release@3013859bdc (openshift/release#4734), so we know it works. Comma-delimited machines won't work, as described in that release commit. I'd be surprised if space-delimited worked.

[wking]

Or maybe it works accidentally now because we have poor quoting/validation ;).

[wking]

Pushed an additional commit to catch up with openshift/installer#1822, which should be backported to 4.2, but not to 4.1.

[kalexand-rh]

Thank you for the update! I might change it up a bit.

[wking]

Squashed in your suggestions.

[kalexand-rh]

@wking, you'll eventually need to squash to one commit.

@shlao, will you PTAL?

[wking]

you'll eventually need to squash to one commit.

Because of the different backport depths, I just spun the second commit off into its own PR (#17651). This one can go back to 4.1 and 4.2.

[kalexand-rh]

@shlao, will you PTAL?

[shlao]

@ahardin-rh it's good, but In big Corps, there are, maybe, more than 3 masters.
Can we use this output?

 --master <master_3_address>" (3)
... ...
 --master <master_N_address>" (N)

[kalexand-rh]

@ahardin-rh it's good, but In big Corps, there are, maybe, more than 3 masters.
Can we use this output?

 --master <master_3_address>" (3)
... ...
 --master <master_N_address>" (N)

I think that that would make the command harder to use, but we can be more explicit in the note. @wking, what do you think of the commit that I added?

[wking]

I've pushed 0b1e9890c -> 518234b7e, softening @kalexand-rh's wording a bit to drop the "must" and allowing for clusters with fewer control plane machines (we may not support one or two control plane machines, but the gather logic doesn't care about that).

[kalexand-rh]

I think this will work. Thank you!

[kalexand-rh]

/cherrypick enterprise-4.2

[kalexand-rh]

/cherrypick enterprise-4.3

[openshift-cherrypick-robot]

@kalexand-rh: new pull request created: #18022

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@kalexand-rh: new pull request created: #18023

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.