Add merge-json-log to event router#17040
Conversation
|
The preview will be available shortly at: |
|
Hold PR pending possible code change per @richm |
|
nack - so the PR openshift/origin-aggregated-logging#1766 will basically enable merge_json_log implicitly for eventrouter events (assuming the documentation has been followed to deploy the eventrouter) - with that PR, the user does not have to enable |
There was a problem hiding this comment.
Fluentd will automatically parse JSON logs that come from Pods whose names match eventrouter-*, which is the naming convention used in the example configuration.
There was a problem hiding this comment.
That is, I don't think we should mention MERGE_JSON_LOG here.
There was a problem hiding this comment.
Instead of this, say something like
You must set `TRANSFORM_EVENTS=true` in order to process and store eventrouter events in Elasticsearch. In order to do this, you must set cluster logging to the unmanaged state.
Then add a link to the docs where we explain how to set cluster logging to the unmanaged state. Then
oc set env ds/fluentd TRANSFORM_EVENTS=true
It depends - if we have already documented that you have to set |
Sorry, I didn't see your comment on TRANSFORM_EVENTS until after I posted that comment. |
633a3ac to
f56c4f2
Compare
|
@anpingli Can I ask you to take another look based on Rich's comments? |
https://bugzilla.redhat.com/show_bug.cgi?id=1758222