-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Change the instructions in favor of local storage for Prometheus and AM #16586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the instructions in favor of local storage for Prometheus and AM #16586
Conversation
|
The preview will be available shortly at: |
|
@ahardin-rh Could you please review this? (also to be merged to enterprise-4.2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/And to/To
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/dynamically-provisioned/dynamically provisioned
|
Just a few minor comments. Otherwise, looks great! |
|
@ahardin-rh Thank you! Last commit implements those two suggestions. |
|
@rh-max Can you please squash? Then, I will merge and cherry-pick 🍒 |
Minor language fixes
166ba7e to
b852e0e
Compare
|
@ahardin-rh Sure, done! I keep forgetting to squash... |
|
/cherrypick enterprise-4.2 |
|
@ahardin-rh: new pull request created: #16744 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| resources: | ||
| requests: | ||
| storage: *_40Gi_* | ||
| storage: *_amount of storage_* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We aren't using this styling for our YAML annotations (https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc#quick-markup-reference).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, implemented this in #16978.
No description provided.