Skip to content

Conversation

@rh-max
Copy link
Contributor

@rh-max rh-max commented Sep 11, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2019
@openshift-docs-preview-bot

The preview will be available shortly at:

@rh-max
Copy link
Contributor Author

rh-max commented Sep 18, 2019

@ahardin-rh Could you please review this? (also to be merged to enterprise-4.2)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/And to/To

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/dynamically-provisioned/dynamically provisioned

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 18, 2019
@ahardin-rh
Copy link
Contributor

Just a few minor comments. Otherwise, looks great!

@rh-max
Copy link
Contributor Author

rh-max commented Sep 18, 2019

@ahardin-rh Thank you! Last commit implements those two suggestions.

@ahardin-rh
Copy link
Contributor

@rh-max Can you please squash? Then, I will merge and cherry-pick 🍒

@rh-max rh-max force-pushed the monitoring-local-persistent-storage branch from 166ba7e to b852e0e Compare September 18, 2019 19:13
@rh-max
Copy link
Contributor Author

rh-max commented Sep 18, 2019

@ahardin-rh Sure, done! I keep forgetting to squash...

@ahardin-rh ahardin-rh merged commit ac1d7af into openshift:master Sep 18, 2019
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.2

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #16744

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

resources:
requests:
storage: *_40Gi_*
storage: *_amount of storage_*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, implemented this in #16978.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.2 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants