Add the tolerations for monitoring components section #16575
Conversation
openshift-ci-robot
added
the
size/M
|
@ahardin-rh Hi, could you please review this? |
rh-max
force-pushed
the
monitoring-tolerations
branch
from
2ad5f18 to
b796958
Compare
ahardin-rh
added
peer-review-done
|
@rh-max Just one minor comment from me. 👍 Once you submit a fix, please squash all commits into one and I will merge and cherry-pick. 🚀 |
Try to fix an internal reference Change the toleration example to a less confusing one Try to fix an xref
rh-max
force-pushed
the
monitoring-tolerations
branch
from
cfb2a98 to
e7c62a8
Compare
|
@ahardin-rh Let me reject the suggestion, I use "Make sure" consistently throughout monitoring and changing it to "Ensure" everywhere wouldn't work from the grammar standpoint in some cases. And they mean the same thing, although "Ensure" is more formal. |
|
@rh-max Works for me. Thanks! |
|
@ahardin-rh You merged before I finish the comment :) Let me know if you insist on the ^ suggestion. |
|
/cherrypick enterprise-4.2 |
|
@ahardin-rh: new pull request created: #16745 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ahardin-rh Great! |
| + | ||
| Substitute `<component>` and `<toleration specification>` accordingly. | ||
| + | ||
| For example, a `kubectl taint nodes node1 key1=value1:NoSchedule` taint prevents the scheduler from placing pods in `foo: bar`. To make the `alertmanagerMain` component ignore that taint and to place `alertmanagerMain` in `foo: bar` normally, use this toleration: |
There was a problem hiding this comment.
kubectl taint nodes node1 key1=value1:NoSchedule
=>
oc adm taint nodes node1 key1=value1:NoSchedule
prevents the scheduler from placing pods in foo: bar
=>
prevents the scheduler from placing pods in foo: bar node
6 participants
No description provided.