Skip to content

Conversation

@bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Sep 10, 2019

This PR will replace #16392.

@bergerhoffer bergerhoffer added this to the Future Release milestone Sep 10, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2019
@openshift-docs-preview-bot

The preview will be available shortly at:

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Sep 10, 2019

@bergerhoffer
Copy link
Contributor Author

@openshift/team-documentation For peer review please.

@bergerhoffer bergerhoffer changed the title [WIP] PROD-615-proxy-enablement PROD-615-proxy-enablement Sep 11, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2019
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think the final object is simply:

apiVersion: config.openshift.io/v1
kind: Proxy
metadata:
  name: cluster
spec:
  trustedCA:
    name: ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example should be:

$ oc get proxy/cluster -o yaml
apiVersion: config.openshift.io/v1
kind: Proxy
metadata:
  name: cluster
spec: {}
status: {}

@jboxman I have an open question with the installer team regarding why this field is being set when spec should be spec: {}. It's harmless that the field is set to an empty string, but may cause confusion and docs inaccuracies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes a lot more sense! Thanks!

@jboxman
Copy link
Contributor

jboxman commented Sep 11, 2019

@bergerhoffer, I took a look. It's late enough I'm hesitant to label Peer review completed though.

@danehans
Copy link
Contributor

@bergerhoffer after reviewing the rendered docs, my biggest concern is the documentation lives under the install section and all the docs in this PR are related to config'ing a proxy post install. The install config (install-config.yaml) is used for installing a cluster with proxy. I cover the install details in slides 12-14 in the presentation I provided you.

@bergerhoffer
Copy link
Contributor Author

@danehans Thank you for the review! Yes I agree. This is where these docs were initially put, so I hadn't moved them yet, but I do think that this location is probably more appropriate for installing a cluster with a proxy (unless there are different steps per provider).

Do you have any suggestions on where it might make most sense to put this. Under networking?

@bergerhoffer
Copy link
Contributor Author

This has been moved under Networking, new preview link is https://osdocs-468--ocpdocs.netlify.com/openshift-enterprise/latest/networking/enable-cluster-wide-proxy.html

@vikram-redhat vikram-redhat added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 23, 2019
@bergerhoffer bergerhoffer merged commit 112cda4 into openshift:master Sep 24, 2019
@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.2

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #16852

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.2 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants