Skip to content

updating CF templates per installer #2296 #16465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kalexand-rh merged 1 commit into from
Sep 3, 2019
Merged

updating CF templates per installer #2296 #16465

kalexand-rh merged 1 commit into from
Sep 3, 2019

Conversation

@kalexand-rh
Copy link
Contributor

@kalexand-rh kalexand-rh commented Sep 2, 2019

Updating the CF templates per https://github.com/openshift/installer/pull/2296/files

@wking, is this valid for just 4.2 or for 4.1 as well?

@jianlinliu, will you PTAL?

@kalexand-rh kalexand-rh added this to the Next Release milestone Sep 2, 2019
@kalexand-rh kalexand-rh self-assigned this Sep 2, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 2, 2019
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Sep 2, 2019

The preview will be available shortly at:

@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Sep 2, 2019

Trevor confirmed that this was valid in 4.1 and 4.2 via Slack.

@jianlinliu
Copy link

jianlinliu commented Sep 3, 2019

After applied the PR, installation get successful. LGTM.

@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Sep 3, 2019

Thank you both! Merging.

@kalexand-rh kalexand-rh merged commit b7b86fa into openshift:master Sep 3, 2019
@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Sep 3, 2019

/cherrypick enterprise-4.1

@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Sep 3, 2019

/cherrypick enterprise-4.2

@kalexand-rh kalexand-rh deleted the installer_2296 branch September 3, 2019 12:05
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 3, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 3, 2019

@kalexand-rh: new pull request created: #16472

Details

In response to this:

/cherrypick enterprise-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 3, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 3, 2019

@kalexand-rh: new pull request created: #16473

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wking wking wking approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kalexand-rh kalexand-rh

Labels

branch/enterprise-4.1 branch/enterprise-4.2 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@kalexand-rh @openshift-docs-preview-bot @jianlinliu @openshift-cherrypick-robot @wking @openshift-ci-robot