modules/machineset-*: Drop openshiftClusterID

[wking]

The installer no longer sets this since openshift/installer@56f47611 (openshift/installer#1280).

[kalexand-rh]

Thanks @wking! @sunzhaohua2, will you PTAL?

[wking]

Spun off from https://bugzilla.redhat.com/show_bug.cgi?id=1685089

[kalexand-rh]

@sunzhaohua2, will you PTAL?

[kalexand-rh]

@sunzhaohua2, will you PTAL?

[kalexand-rh]

@sunzhaohua2, will you PTAL?

[kalexand-rh]

@jianlinliu, will you PTAL? I know that @sunzhaohua2 owns the machine stuff, but this is related to #14549 https://bugzilla.redhat.com/show_bug.cgi?id=1685089, which you're listed as the QE contact for.

[jianlinliu]

I do not think this is related to https://bugzilla.redhat.com/show_bug.cgi?id=1685089#c11, in 1685089, the reproduce steps are really clean and simple.
Create a cluster using openshift-install;
Generate metadata.json manually using some aws command
Destroy the whole cluster using the metadata.json.

There is no any intervention with machineset stuff. Do I miss something?

[wking]

There is no any intervention with machineset stuff.

Adjusting the MachineSet, like I'm doing here, catches these docs up with this installer change. The registry's S3 tagging is completely separate, and I'm working up a PR to fix their tagging while porting them off cluster-config-v1, but the PR isn't filed yet. Still, I don't see any need to hold this PR based on the registry's tagging, MachineSets are orthogonal.

[sunzhaohua2]

Now for machineset, LGTM.

[kalexand-rh]

Then I'm going to merge this one. @wking, let me know if the registry change has a doc impact, too. Thanks!