Skip to content

Conversation

@kalexand-rh
Copy link
Contributor

@kalexand-rh kalexand-rh commented Aug 3, 2018

@kalexand-rh kalexand-rh added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2018
@kalexand-rh kalexand-rh self-assigned this Aug 3, 2018
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 6, 2018
@kalexand-rh kalexand-rh added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2018
@kalexand-rh kalexand-rh force-pushed the install_4.0 branch 3 times, most recently from 8d21e11 to 37359d2 Compare August 6, 2018 15:43
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are calling these "installation targets" and they are called "config" (or maybe "install-config"), "manifests", "ignition-configs", and "cluster". Nouns make a little more sense here because that is what is being installed. We are working on those definitions in the installer repo.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2018
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2018
@kalexand-rh kalexand-rh removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2018
@kalexand-rh kalexand-rh merged commit 824a35c into openshift:enterprise-4.0 Aug 30, 2018
@kalexand-rh
Copy link
Contributor Author

This is still very much WIP, but I'm posting the draft to validate the structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants