Skip to content

Revert #288 "API-1644: Use bound service account tokens when generating pull secrets" #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
May 13, 2024
Merged

Revert #288 "API-1644: Use bound service account tokens when generating pull secrets" #304

openshift-merge-bot merged 1 commit into from
May 13, 2024

Conversation

@neisw
Copy link
Contributor

@neisw neisw commented May 12, 2024

Reverts #288 ; tracked by https://issues.redhat.com/browse/TRT-1665

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to hypershift conformance test failures

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

CC: @sanchezl

PR created by Revertomatic™️

@neisw
Revert "Merge pull request openshift#288 from sanchezl/pull-secret-co…
71a085e 
…ntroller-v2"

This reverts commit 3c219f6, reversing
changes made to bfd3b98.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 12, 2024 •
edited by openshift-ci bot
Loading

@neisw: This pull request references API-1644 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Reverts #288 ; tracked by https://issues.redhat.com/browse/TRT-1665

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to hypershift conformance test failures

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

CC: @sanchezl

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from mfojtik and sayan-biswas May 12, 2024 23:45
@neisw
Copy link
Contributor Author

neisw commented May 12, 2024

/payload-job periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2024

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c66c1160-10b9-11ef-9ee7-80b1ed7f9229-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2024

@neisw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 71a085e link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@neisw
Copy link
Contributor Author

neisw commented May 13, 2024

/label px-approved
/label docs-approved
/label qe-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels May 13, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot
Loading

@neisw: This pull request references API-1644 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Reverts #288 ; tracked by https://issues.redhat.com/browse/TRT-1665

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to hypershift conformance test failures

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

CC: @sanchezl

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam
Copy link
Member

stbenjam commented May 13, 2024

/lgtm

@stbenjam
Copy link
Member

stbenjam commented May 13, 2024

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 13, 2024
soltysh
soltysh approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@stbenjam
Copy link
Member

stbenjam commented May 13, 2024

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, soltysh, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0adb6e1 into openshift:master May 13, 2024
@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-openshift-controller-manager-container-v4.17.0-202405132002.p0.g0adb6e1.assembly.stream.el9 for distgit ose-openshift-controller-manager.
All builds following this will include this PR.

@sanchezl sanchezl mentioned this pull request May 14, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented May 16, 2024

Fix included in accepted release 4.16.0-0.nightly-2024-05-16-092402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sayan-biswas sayan-biswas Awaiting requested review from sayan-biswas

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stbenjam stbenjam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@neisw @openshift-ci-robot @stbenjam @openshift-bot @openshift-merge-robot @soltysh