Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in conext/set_default_oc_path docstring #120

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

tonejito
Copy link
Contributor

Fixed a typo in the docstring for function set_default_oc_path in the packages/openshift/context.py file.

Fixed a typo in the docstring for function `set_default_oc_path` in the `packages/openshift/context.py` file.
@bradmwilliams
Copy link
Contributor

@tonejito Please run ./ansible/rebuild_module.sh and include any additional files to your PR.
Thanks!

@bradmwilliams
Copy link
Contributor

/retest

@bradmwilliams
Copy link
Contributor

/test all

@bradmwilliams
Copy link
Contributor

/retest

@tonejito
Copy link
Contributor Author

@bradmwilliams I updated the digests produced by ./ansible/rebuild_module.sh

@tonejito
Copy link
Contributor Author

/test all

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2022

@tonejito: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bradmwilliams
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 1, 2022

@tonejito: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, tonejito

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022
@bradmwilliams
Copy link
Contributor

@tonejito Thanks for your contribution!
Sorry for all the noise over the past few days!

@openshift-merge-robot openshift-merge-robot merged commit 263e9c3 into openshift:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants