verify generated mocks are up to date

[0xmichalis]

If I go generate ./... in the current HEAD, I get a diff in the mocking clients. We probably need to verify these in hack/validate-generated.sh to avoid drifting.

/assign @asalkeld
/kind bug

[asalkeld]

@Kargakis this code should check it: https://github.com/openshift/openshift-azure/blob/master/hack/validate-generated.sh#L23

if you run "make verify" does it not catch the diff?

1. what version of go do you have?
2. what is the diff that you get?

for me:

[angus] ~/.../openshift/openshift-azure  (master)$ git pull
Already up to date.
[angus] ~/.../openshift/openshift-azure  (master)$ go generate ./...
bindata.go
bindata.go
[angus] ~/.../openshift/openshift-azure  (master)$ git diff
[angus] ~/.../openshift/openshift-azure  (master)$ 

Also my verify does check the mocks

[angus] ~/.../openshift/openshift-azure  (master)$ make verify 
./hack/validate-generated.sh
++ mktemp -d
+ T=/tmp/tmp.NwRUY7Jds5
+ trap 'rm -rf /tmp/tmp.NwRUY7Jds5' EXIT
+ cp -a /home/angus/go/src/github.com/openshift/openshift-azure/hack/.. /tmp/tmp.NwRUY7Jds5/
+ cd /tmp/tmp.NwRUY7Jds5/
+ go generate ./...
bindata.go
bindata.go
++ git grep --name-only 'Code generated by .* DO NOT EDIT.*' -- ':^vendor' ':^hack'
+ GENERATED_FILES='pkg/addons/bindata.go
pkg/arm/bindata.go
pkg/jsonpath/parser.go
pkg/util/mocks/mock_arm/arm.go
pkg/util/mocks/mock_azureclient/azureclient.go
pkg/util/mocks/mock_azureclient/mock_storage/storage.go
pkg/util/mocks/mock_upgrade/types.go
pkg/util/mocks/mock_wait/wait.go'
+ for file in ${GENERATED_FILES}
+ diff -r /home/angus/go/src/github.com/openshift/openshift-azure/hack/../pkg/addons/bindata.go /tmp/tmp.NwRUY7Jds5/pkg/addons/bindata.go
+ for file in ${GENERATED_FILES}
+ diff -r /home/angus/go/src/github.com/openshift/openshift-azure/hack/../pkg/arm/bindata.go /tmp/tmp.NwRUY7Jds5/pkg/arm/bindata.go
+ for file in ${GENERATED_FILES}
+ diff -r /home/angus/go/src/github.com/openshift/openshift-azure/hack/../pkg/jsonpath/parser.go /tmp/tmp.NwRUY7Jds5/pkg/jsonpath/parser.go
+ for file in ${GENERATED_FILES}
+ diff -r /home/angus/go/src/github.com/openshift/openshift-azure/hack/../pkg/util/mocks/mock_arm/arm.go /tmp/tmp.NwRUY7Jds5/pkg/util/mocks/mock_arm/arm.go
+ for file in ${GENERATED_FILES}
+ diff -r /home/angus/go/src/github.com/openshift/openshift-azure/hack/../pkg/util/mocks/mock_azureclient/azureclient.go /tmp/tmp.NwRUY7Jds5/pkg/util/mocks/mock_azureclient/azureclient.go
+ for file in ${GENERATED_FILES}
+ diff -r /home/angus/go/src/github.com/openshift/openshift-azure/hack/../pkg/util/mocks/mock_azureclient/mock_storage/storage.go /tmp/tmp.NwRUY7Jds5/pkg/util/mocks/mock_azureclient/mock_storage/storage.go
+ for file in ${GENERATED_FILES}
+ diff -r /home/angus/go/src/github.com/openshift/openshift-azure/hack/../pkg/util/mocks/mock_upgrade/types.go /tmp/tmp.NwRUY7Jds5/pkg/util/mocks/mock_upgrade/types.go
+ for file in ${GENERATED_FILES}
+ diff -r /home/angus/go/src/github.com/openshift/openshift-azure/hack/../pkg/util/mocks/mock_wait/wait.go /tmp/tmp.NwRUY7Jds5/pkg/util/mocks/mock_wait/wait.go
+ echo 'Generated assets have no material difference than what is committed.'
Generated assets have no material difference than what is committed.
+ rm -rf /tmp/tmp.NwRUY7Jds5
go vet ./...
./hack/verify-code-format.sh

[asalkeld]

if you have go 1.11 beware of this: golang/go#25161
I upgraded to fedora 29 and had to install 1.10 to not get gofmt diffs.

[0xmichalis]

This was not caught by CI.

…

On Tue, Nov 6, 2018, 01:16 Angus Salkeld ***@***.*** wrote: if you have go 1.11 beware of this: golang/go#25161 <golang/go#25161> I upgraded to fedora 29 and had to install 1.10 to not get gofmt diffs. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#690 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADuFf_IQL7q4-QKi_wC18I3S4oUS-Maqks5usNTJgaJpZM4YOkbc> .

[asalkeld]

@Kargakis it is still not clear what needs to be done here, can you be more specific please?

[0xmichalis]

@asalkeld in d8a538d I submitted generated code about one of the azure clients w/o touching that client. Seems that the generated files are not compared correctly in CI. I just run the command from validate-generated.sh locally and I get no output (no files returned from grep). The same thing seems to happen in CI, eg. see https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_openshift-azure/683/pull-ci-openshift-openshift-azure-master-verify/513/build-log.txt where GENERATED_FILES is empty.

[0xmichalis]

For example, I submitted an invalid change in #735 but the verify job is green: https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-azure/735/pull-ci-openshift-openshift-azure-master-verify/632