OCPBUGS-31666: Bump openshift/api for Route API godoc fix by Miciah · Pull Request #433 · openshift/openshift-apiserver

Miciah · 2024-04-30T21:04:10Z

Bump to openshift/api@8203151, which fixes the godoc for the Route.spec.tls.insecureEdgeTerminationPolicy field to say that "None", not "Allow", is the default value.

Bump to openshift/library-go@cb8aac9 to fix build errors in library-go resulting from changes in openshift/api.

Update NewOpenshiftAPIConfig likewise to read feature definitions from their new location in openshift/api.

Follow-up to openshift/api#1845.

openshift-ci-robot · 2024-04-30T21:04:17Z

@Miciah: This pull request references Jira Issue OCPBUGS-31666, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump to github.com/openshift/api@8203151f085f2205ba7fa64f093a04a742d1cb87, which fixes the godoc for the Route.spec.tls.insecureEdgeTerminationPolicy field to say that "None", not "Allow", is the default value.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Miciah · 2024-05-01T13:15:14Z

https://github.com/openshift/openshift-apiserver/compare/4b0a7a5ef1bcdcb7dfc6fed1f89b0632ecd11d96..f15a6b96f2cf13e83ac665f3c644e51b36be2744 bumps the vendored library-go to fix build errors that resulted from the openshift/api bump.

Miciah · 2024-05-01T14:54:41Z

https://github.com/openshift/openshift-apiserver/compare/f15a6b96f2cf13e83ac665f3c644e51b36be2744..b3335a8d02a3cc20d95dbd908e59b209872b98d7 fixes one more build error resulting from the openshift/api bump.

openshift-ci-robot · 2024-05-01T14:55:20Z

@Miciah: This pull request references Jira Issue OCPBUGS-31666, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

Details

In response to this:

Bump to github.com/openshift/api@8203151f085f2205ba7fa64f093a04a742d1cb87, which fixes the godoc for the Route.spec.tls.insecureEdgeTerminationPolicy field to say that "None", not "Allow", is the default value.

Bump to github.com/openshift/library-go@cb8aac942b79e973d2c37168ccff36c882200856 to fix build errors in library-go resulting from changes in openshift/api.

Update NewOpenshiftAPIConfig likewise to read feature definitions from their new location in openshift/api.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Bump to github.com/openshift/api@8203151f085f2205ba7fa64f093a04a742d1cb87, which fixes the godoc for the Route.spec.tls.insecureEdgeTerminationPolicy field to say that "None", not "Allow", is the default value. Bump to github.com/openshift/library-go@cb8aac942b79e973d2c37168ccff36c882200856 to fix build errors in library-go resulting from changes in openshift/api. Update NewOpenshiftAPIConfig likewise to read feature definitions from their new location in openshift/api. go get github.com/openshift/api@8203151f085f2205ba7fa64f093a04a742d1cb87 \ github.com/openshift/library-go@cb8aac942b79e973d2c37168ccff36c882200856 go mod tidy go mod vendor This commit fixes OCPBUGS-31666. https://issues.redhat.com/browse/OCPBUGS-31666 * go.mod: Bump. * go.sum: * hack/openapi-violation.list: * pkg/openapi/zz_generated.openapi.go: * vendor/*: Regenerate. * pkg/cmd/openshift-apiserver/cmd.go (RunAPIServer): * pkg/cmd/openshift-apiserver/openshiftapiserver/config.go (NewOpenshiftAPIConfig): Read feature definitions from their new location in the "github.com/openshift/api/features" package.

Miciah · 2024-05-02T03:34:58Z

https://github.com/openshift/openshift-apiserver/compare/b3335a8d02a3cc20d95dbd908e59b209872b98d7..b983b70ed06cf64f18cd5420f963f315d120fe6a fixes some more build failures from the openshift/api bump.

openshift-ci · 2024-05-02T06:19:13Z

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ShudiLi · 2024-05-08T04:01:49Z

tested it with 4.16.0-0.ci.test-2024-05-08-031552-ci-ln-hmrbdf2-latest: If a route does not specify insecureEdgeTerminationPolicy, then the default behavior is "None".

1.
% oc get clusterversion   
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.16.0-0.ci.test-2024-05-08-031552-ci-ln-hmrbdf2-latest   True        False         6m17s   Cluster version is 4.16.0-0.ci.test-2024-05-08-031552-ci-ln-hmrbdf2-latest
% 

2.
% oc explain routes.spec.tls.insecureEdgeTerminationPolicy
GROUP:      route.openshift.io
KIND:       Route
VERSION:    v1

FIELD: insecureEdgeTerminationPolicy <string>

DESCRIPTION:
    insecureEdgeTerminationPolicy indicates the desired behavior for insecure
    connections to a route. While each router may make its own decisions on
    which ports to expose, this is normally port 80.
    
    If a route does not specify insecureEdgeTerminationPolicy, then the default
    behavior is "None".
    
    * Allow - traffic is sent to the server on the insecure port (edge/reencrypt
    terminations only).
    
    * None - no traffic is allowed on the insecure port (default).
    
    * Redirect - clients are redirected to the secure port.
    

%

ShudiLi · 2024-05-08T04:05:07Z

/label qe-approved
thanks

p0lyn0mial · 2024-05-08T07:10:11Z

/lgtm
/approve

openshift-ci · 2024-05-08T07:15:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-05-08T07:20:17Z

@Miciah: Jira Issue OCPBUGS-31666: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31666 has been moved to the MODIFIED state.

Details

In response to this:

Bump to openshift/api@8203151, which fixes the godoc for the Route.spec.tls.insecureEdgeTerminationPolicy field to say that "None", not "Allow", is the default value.

Bump to openshift/library-go@cb8aac9 to fix build errors in library-go resulting from changes in openshift/api.

Update NewOpenshiftAPIConfig likewise to read feature definitions from their new location in openshift/api.

Follow-up to openshift/api#1845.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-05-08T10:06:00Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-openshift-apiserver-container-v4.17.0-202405080245.p0.g11d295e.assembly.stream.el9 for distgit ose-openshift-apiserver.
All builds following this will include this PR.

openshift-merge-robot · 2024-05-09T13:22:48Z

Fix included in accepted release 4.16.0-0.nightly-2024-05-08-222442

openshift-ci bot requested review from ShudiLi, adambkaplan and p0lyn0mial April 30, 2024 21:04

Miciah mentioned this pull request Apr 30, 2024

OCPBUGS-31666: route: Fix insecureEdgeTerminationPolicy default openshift/api#1845

Merged

Miciah force-pushed the OCPBUGS-31666-bump-openshift-slash-api-for-Route-API-godoc-fix branch from 4b0a7a5 to f15a6b9 Compare May 1, 2024 13:14

Miciah force-pushed the OCPBUGS-31666-bump-openshift-slash-api-for-Route-API-godoc-fix branch from f15a6b9 to b3335a8 Compare May 1, 2024 14:54

Miciah force-pushed the OCPBUGS-31666-bump-openshift-slash-api-for-Route-API-godoc-fix branch from b3335a8 to b983b70 Compare May 2, 2024 03:34

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 8, 2024

openshift-ci bot assigned p0lyn0mial May 8, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024

openshift-merge-bot bot merged commit 11d295e into openshift:master May 8, 2024

Conversation

Miciah commented Apr 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 30, 2024

Uh oh!

Miciah commented May 1, 2024

Uh oh!

Miciah commented May 1, 2024

Uh oh!

openshift-ci-robot commented May 1, 2024

Uh oh!

Miciah commented May 2, 2024

Uh oh!

openshift-ci bot commented May 2, 2024

Uh oh!

ShudiLi commented May 8, 2024

Uh oh!

ShudiLi commented May 8, 2024

Uh oh!

p0lyn0mial commented May 8, 2024

Uh oh!

openshift-ci bot commented May 8, 2024

Uh oh!

openshift-ci-robot commented May 8, 2024

Uh oh!

openshift-bot commented May 8, 2024

Uh oh!

openshift-merge-robot commented May 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Miciah commented Apr 30, 2024 •

edited

Loading