OCPBUGS-26498: Vendor route API change for UnservableInFutureVersions status#414
OCPBUGS-26498: Vendor route API change for UnservableInFutureVersions status#414gcs278 wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
@gcs278: This pull request references Jira Issue OCPBUGS-26498, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
abeedc4 to
58eb250
Compare
Vendoring API to update the go docs for UnservableInFutureVersions condition. `go get github.com/openshift/api@v0.0.0-20240202140003-8b34b9854c7f`
|
I'll do a sanity check test, but feel free to review |
|
Sanity checked ✔️ |
|
@gcs278: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: frobware, gcs278 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No longer needed as openshift/api was bumped to also include the route API update in #407 |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gcs278: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gcs278: This pull request references Jira Issue OCPBUGS-26498. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Vendor the route API change in openshift/api#1722 in order to get the GO doc updates for
oc explain route.status.ingress.conditionssince theUnservableInFutureVersionsstatus condition type was added.